SUMMARY Currently we have close window shortcut (bound to alt+f4 by default) which closes window in focus. Can we add a shortcut that would close all windows from the app (we can bound it to alt+shift+f4). It would be useful if you open 5 Dolphin windows for some reason, just run the shortcut to close all of them.
On MacOS, this is what Ctrl+Q does. Of course in our world, Ctrl+Q is application-defined and usually just closes the window, rather than doing what you want. It's always been a bit of an annoyance to me that we *have* a Ctrl+Q shortcut but it functions mostly as a less consistent version of Alt+F4 rather than doing what you're asking for.
It's actually command+Q on macOS and I agree about the Ctrl+Q. Is there a reason why we have it, would it be good to remove it?
Right yeah, Command+Q. Is there a reason why we have *what*, and would it be good to remove *what*?
I was talking about the Ctrl+Q shortcut. Would it be beneficial to remove Ctrl+Q shortcut, would it break anything? And just leave the Alt+F4 shortcut.
Well yes, it would break the muscle memory of everyone using that shortcut.
I see, if it's only that, then it sounds to me like we can remove it :) Just joking, but kinda not. If it's not consistent then it's not a good shortcut. Close window works a bit better so it might be good to discuss further about removing it. I know someone would complain, but they can use close window. They'll get used to it and they can rebind it. Although it doesn't cost us anything to keep it, not forcing anything.
What makes more sense IMO is to re-define with Ctrl+Q does so that it terminates all windows and instances of the app. However as I mentioned, it's currently a shortcut that gets registered by the app rather than the window manager, so this would require one of the following: 1. Changing every app in existence to have that new different behavior 2. Implementing it at the KWin level and then remove it from every app in existence 3. Implementing it at the KWin level and making KWin ignore Ctrl+Q implemented by apps 1 is best since it would allow apps to perform cleanup before quitting. 2 and 3 would have more problems.
hmm, this goes over my head right now, and it looks like a lot of work for a seemingly small change. I guess only 3 would be possible to do, but it looks like it's best to leave it as is and I don't want to spend to much of your time on this discussion. And I have a feeling that when you were talking about ctrl+Q shortcut, you thought about the proposed change (shortcut would close all windows and instances of the app). For me that was just off topic and I didn't notice that I guess. Sorry for confusion if that's the case haha. Just to repeat one more time. The proposal was to create a new shortcut that would close all windows from the app. It would work like close window, but would close all windows so there would be no modifying of Ctrl+Q shortcut
(In reply to Filip from comment #8) > hmm, this goes over my head right now, and it looks like a lot of work for a > seemingly small change. Welcome to the wild and wonderful world of software development :) > Just to repeat one more time. The proposal was to create a new shortcut that > would close all windows from the app. It would work like close window, but > would close all windows so there would be no modifying of Ctrl+Q shortcut We could conceivably create a new shortcut in KWin for this like Alt+Shift+F4 like you suggested, it's just that it would probably not be used by anyone since this is a non-standard shortcut that exists nowhere else, and hence would not be discoverable. That's why I switched to talking about changing Ctrl+Q to do this, since it's what I think people expect that shortcut to do already.
Aha, yeah, that makes sense.
*** Bug 506695 has been marked as a duplicate of this bug. ***
> 2. Implementing it at the KWin level and then remove it from every app in existence > 3. Implementing it at the KWin level and making KWin ignore Ctrl+Q implemented by apps These approches won't work well to support the use case described in https://bugs.kde.org/show_bug.cgi?id=506695: if KWin closes all Dolphin windows one by one, only the last window will be restored upon restart of Dolphin. Dolphin should get some sort of signal from user/from KWin to store states of all its windows in order to support that user journey.
*** Bug 506788 has been marked as a duplicate of this bug. ***