Bug 492436 - Round corner missing for Digital Clock popup
Summary: Round corner missing for Digital Clock popup
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Calendar (show other bugs)
Version: 6.1.4
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
: 493641 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-08-31 03:36 UTC by jian
Modified: 2024-09-25 20:05 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.2.0
Sentry Crash Report:


Attachments
The alternate calendar view with top corners circled (371.66 KB, image/png)
2024-08-31 03:36 UTC, jian
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jian 2024-08-31 03:36:14 UTC
Created attachment 173155 [details]
The alternate calendar view with top corners circled

SUMMARY
The round corners are missing for alternate calendar.

STEPS TO REPRODUCE
1. Enable alternate calendar for digital clock widget.
2. Click the widget to open calendar view.

OBSERVED RESULT
The corners on the top of the calendar view are both square.

EXPECTED RESULT
The corners on the top of the calendar view should be round, like the view without alternate calendar enabled.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora 40 KDE spin
KDE Plasma Version: 6.1.4
KDE Frameworks Version: 6.5.0
Qt Version: 6.7.2
Comment 1 Justin Zobel 2024-09-02 08:13:28 UTC
Confirmed on Plasma from git master, both regular and alternative calendar are not rounded, unlike other applets.
Comment 2 jian 2024-09-03 06:49:00 UTC
Sorry for the special note regarding enabling the Alternate Calendar. This issue should occur regardless of whether it is enabled or not.
Comment 3 Nate Graham 2024-09-05 20:15:07 UTC
Can also reproduce with Breeze Light on current git master, irrespective of which calendars are enabled.
Comment 4 Bug Janitor Service 2024-09-18 14:26:51 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libplasma/-/merge_requests/1197
Comment 5 Niccolò Venerandi 2024-09-18 15:26:18 UTC
Git commit a47113c9657cbc62b05d02963d2122802281805f by Niccolò Venerandi.
Committed on 18/09/2024 at 15:26.
Pushed by niccolove into branch 'master'.

Handle floating point position and size for PlasmoidHeading logic

It seems like the x position of the digital clock PlasmoidHeading is 2e-23 (I did not see why it assumed that value, maybe has to do with fractional scaling?); and, the size is also a fraction short of the window width. Just for sure, I add here some logic to add with non-integer position and sizes, since the rounded corners depend on it. 
FIXED-IN: 6.2.0

M  +2    -2    src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml

https://invent.kde.org/plasma/libplasma/-/commit/a47113c9657cbc62b05d02963d2122802281805f
Comment 6 Niccolò Venerandi 2024-09-18 15:26:30 UTC
Git commit 4c938b46745580a34eb0194a517750774102d6d4 by Niccolò Venerandi.
Committed on 18/09/2024 at 15:26.
Pushed by niccolove into branch 'Plasma/6.2'.

Handle floating point position and size for PlasmoidHeading logic

It seems like the x position of the digital clock PlasmoidHeading is 2e-23 (I did not see why it assumed that value, maybe has to do with fractional scaling?); and, the size is also a fraction short of the window width. Just for sure, I add here some logic to add with non-integer position and sizes, since the rounded corners depend on it. 
FIXED-IN: 6.2.0


(cherry picked from commit a47113c9657cbc62b05d02963d2122802281805f)

333cdc09 Handle floating point position and size for PlasmoidHeading logic

Co-authored-by: Niccolò Venerandi <niccolo@venerandi.com>

M  +2    -2    src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml

https://invent.kde.org/plasma/libplasma/-/commit/4c938b46745580a34eb0194a517750774102d6d4
Comment 7 Nate Graham 2024-09-25 20:05:56 UTC
*** Bug 493641 has been marked as a duplicate of this bug. ***