Bug 491368 - office/alkimia: some po files do not use the real package name
Summary: office/alkimia: some po files do not use the real package name
Status: RESOLVED FIXED
Alias: None
Product: alkimia
Classification: Frameworks and Libraries
Component: General (show other bugs)
Version: master
Platform: Other Other
: NOR minor
Target Milestone: ---
Assignee: Ralf Habacker
URL:
Keywords:
Depends on:
Blocks: 488491
  Show dependency treegraph
 
Reported: 2024-08-06 23:58 UTC by Ralf Habacker
Modified: 2024-10-24 04:37 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 8.1.80
Sentry Crash Report:


Attachments
Patch (13.65 KB, patch)
2024-08-06 23:58 UTC, Ralf Habacker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2024-08-06 23:58:00 UTC
Created attachment 172365 [details]
Patch

STEPS TO REPRODUCE
1. see appended patch 

OBSERVED RESULT
Several po files contains the term 'PACKAGE' instead of the real package name

-# This file is distributed under the same license as the PACKAGE package.

EXPECTED RESULT
The related po files should contain the real package name

+# This file is distributed under the same license as the alkimia package.
Comment 1 Andre Heinecke 2024-08-07 11:43:09 UTC
This is not the correct place to fix this as the po files are something that is generated. Changing it in the package will be overwritten by the translation system the next time updated translations are transfered from svn to the projects repository. 

This must be fixed somewhere on the message extraction side and I do not know how this works or who the right assignee is for that.  I think that alkimia porobably needs a Messages.sh file so that the scripting can use that to extract the messages. This is likely documented somewhere. :)

Since there is no Product for Alkimia i cannot change the product to it so I am setting this to unknown product, but looking for contributors there, you are one :) So back to you, because keeping it assigned to the german l10n team won't fix this as we have no influence on that part and even your patch is not in any way specific to german.
Comment 2 Ralf Habacker 2024-08-07 12:09:55 UTC
(In reply to Andre Heinecke from comment #1)

Thanks for the response. 

> This must be fixed somewhere on the message extraction side 
> and I do not  know how this works or who the right assignee is for that.  
> I think that  alkimia porobably needs a Messages.sh file so that the scripting can use
> that to extract the messages.

It works for most file, but not for a few one:

~/src/alkimia> grep -rn "alkimia package" po | wc -l
69
~/src/alkimia> grep -rn "PACKAGE package" po | wc -l
24

> Since there is no Product for Alkimia i cannot change the product to it so I
> am setting this to unknown product, 

it is currently named libalkimia - I changed that accordingly

> keeping it assigned to the german l10n team won't fix this 

I choosed 'de' as there was no 'common' category for reporting such issues.

I finaly found a source files in the svn repo, https://websvn.kde.org/trunk/l10n-kf5/de/messages/alkimia/alkimia.po?revision=1685818&view=markup. 

According to https://l10n.kde.org/docs/translation-howto/gui-todo-lists.html I would need to modify the related files and send the changed files to the kde-i18n-doc AT kde.org mailing list - is this correct ?
Comment 3 Ralf Habacker 2024-08-07 18:06:31 UTC
(In reply to Ralf Habacker from comment #2)
... 
> According to https://l10n.kde.org/docs/translation-howto/gui-todo-lists.html
> I would need to modify the related files and send the changed files to the
> kde-i18n-doc AT kde.org mailing list - is this correct ?

I did send archive with changed files to the mentioned list
Comment 4 Luigi Toscano 2024-08-07 22:07:57 UTC
In any case, this is not a "real" bug, but a very minor thing that doesn't produce any harm (in a comment)
Comment 5 Ralf Habacker 2024-08-08 06:34:36 UTC
(In reply to Luigi Toscano from comment #4)
> In any case, this is not a "real" bug, but a very minor thing that doesn't produce any harm (in a comment)

The problem was noticed when evaluating the results of "reuse". This line makes a statement as to which license this file is under and does not give a clear answer as to which license is being used here with the PACKAGE specification. 

I suspect that this also applies to other projects. At least I noticed this with the kmymoney project.
Comment 6 Ralf Habacker 2024-10-24 04:37:48 UTC
The issue has been fixed in the git repo.