Bug 491355 - NeoChat uses different icons for "log out" buttons/features in different contexts
Summary: NeoChat uses different icons for "log out" buttons/features in different cont...
Status: RESOLVED FIXED
Alias: None
Product: NeoChat
Classification: Applications
Component: General (other bugs)
Version First Reported In: git master
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Tobias Fella
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2024-08-06 15:57 UTC by Nate Graham
Modified: 2024-09-07 12:41 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
`list-remove` on welcome screen (51.31 KB, image/png)
2024-08-06 15:58 UTC, Nate Graham
Details
`list-remove-user` in user context menu (93.41 KB, image/png)
2024-08-06 15:58 UTC, Nate Graham
Details
`im-kick-user` on accounts page (66.57 KB, image/png)
2024-08-06 16:02 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2024-08-06 15:57:49 UTC
See forthcoming attached screenshots.

Icons I've seen used:
- list-remove
- list-remove-user
- im-kick-user

Part of the problem, I suspect, is that we don't actually have a semantically appropriate icon for this in Breeze icons. As a result the people who implemented the various features of NeoChat probably easy ran up against this problem and picked something that looked least-bad to them personally.

We should get a better Breeze icon here for sure. But until that happens, it would be better if NeoChat could settle on a single icon for all of these, ideally defined in a single place so everything could be updated to the new icon (once it exists) with only a one-line code change
Comment 1 Nate Graham 2024-08-06 15:58:20 UTC
Created attachment 172344 [details]
`list-remove` on welcome screen
Comment 2 Nate Graham 2024-08-06 15:58:54 UTC
Created attachment 172345 [details]
`list-remove-user` in user context menu
Comment 3 Nate Graham 2024-08-06 16:02:13 UTC
Created attachment 172346 [details]
`im-kick-user` on accounts page
Comment 4 Bug Janitor Service 2024-09-07 07:58:33 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/1883
Comment 5 James Graham 2024-09-07 12:41:30 UTC
Git commit fc24beae6d009fcb86165f798b1526663edf77ca by James Graham.
Committed on 07/09/2024 at 12:41.
Pushed by nvrwhere into branch 'master'.

Use im-kick-user consistently for logout.

I went with im-kick-user as it's fully red at all sizes.

M  +1    -1    src/login/WelcomePage.qml
M  +1    -1    src/qml/AccountMenu.qml

https://invent.kde.org/network/neochat/-/commit/fc24beae6d009fcb86165f798b1526663edf77ca