Bug 488702 - Icons-and-Text Task Manager renders incorrectly in multi-row view (regression in Plasma 6.1)
Summary: Icons-and-Text Task Manager renders incorrectly in multi-row view (regression...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager (show other bugs)
Version: 6.1.0
Platform: NixOS Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-06-19 00:15 UTC by Kacper Sowa
Modified: 2024-06-24 11:04 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.1.1


Attachments
Task Manager on Plasma 6.1 (57.17 KB, image/png)
2024-06-19 00:15 UTC, Kacper Sowa
Details
Task Manager on Plasma 6.0.5 (61.39 KB, image/png)
2024-06-19 00:16 UTC, Kacper Sowa
Details
Task Manager Settings - Appearance (75.33 KB, image/png)
2024-06-19 00:18 UTC, Kacper Sowa
Details
Task Manager Settings - Behavior (108.95 KB, image/png)
2024-06-19 00:19 UTC, Kacper Sowa
Details
Space around the icon (6.22 KB, image/png)
2024-06-20 14:46 UTC, Kacper Sowa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kacper Sowa 2024-06-19 00:15:48 UTC
Created attachment 170614 [details]
Task Manager on Plasma 6.1

SUMMARY
Icons-and-Text Task Manager renders incorrectly in multi-row view when at least two rows are present. The buttons have incorrect sizes. When there is only one window, it displays in a single row, even though the settings specify it should always use multi-row mode. The icons have incorrect spacing. See the included screenshots of the applet with 1, 2, 3 and 4 windows on Plasma versions 6.0.5 and 6.1 for comparison.

STEPS TO REPRODUCE
1. Add the Icons-and-Text Task Manager applet to the panel, set "Maximum rows" to 2 and "Use multi-row view" to "Always ...". The exact settings are in the screenshots
2. Observe applet when there are 1, 2, 3 and 4 windows open

OBSERVED RESULT
Buttons in the task manager render incorrectly as described in the SUMMARY

EXPECTED RESULT
Buttons should render the same way as in Plasma 6.0.5

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: NixOS Unstable
KDE Plasma Version: 6.1.0
KDE Frameworks Version: 6.3.0
Qt Version: 6.7.1

ADDITIONAL INFORMATION
It works on those versions:
Linux/KDE Plasma: NixOS Unstable
KDE Plasma Version: 6.0.5
KDE Frameworks Version: 6.3.0
Qt Version: 6.7.1
Comment 1 Kacper Sowa 2024-06-19 00:16:22 UTC
Created attachment 170615 [details]
Task Manager on Plasma 6.0.5
Comment 2 Kacper Sowa 2024-06-19 00:18:03 UTC
Created attachment 170616 [details]
Task Manager Settings - Appearance
Comment 3 Kacper Sowa 2024-06-19 00:19:16 UTC
Created attachment 170617 [details]
Task Manager Settings - Behavior
Comment 4 nope1000000 2024-06-19 07:51:51 UTC
And when in multi-row view, the applets don't resize themselves to the size they would have and keep themselves occupying the size they would use if set in single row, which is noticeable as it leaves empty space at the right when panel width is set to adjust to content
Comment 5 Bug Janitor Service 2024-06-19 21:38:12 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2322
Comment 6 Kacper Sowa 2024-06-20 14:46:13 UTC
Created attachment 170684 [details]
Space around the icon

MR 2322 fixes the size of window buttons but does not fix the additional space around the icons.
Comment 7 whatifgodwasoneofus 2024-06-20 22:01:34 UTC
(In reply to Kacper Sowa from comment #6)
> Created attachment 170684 [details]
> Space around the icon
> 
> MR 2322 fixes the size of window buttons but does not fix the additional
> space around the icons.

https://bugs.kde.org/show_bug.cgi?id=488733
Comment 8 Ismael Asensio 2024-06-24 10:55:22 UTC
Git commit a1710e8fe0998a737f32158208ab71b20550dc93 by Ismael Asensio.
Committed on 24/06/2024 at 10:48.
Pushed by iasensio into branch 'master'.

applets/taskmanager: Fix grid layout for forced multiple rows/columns

In the case of forced multiple rows/columns, to calculate the effective
width and height of the TaskList we need to know the exact number of
rows and columns, and also the average occupation of those (fractional
if some rows are not full)
FIXED-IN: 6.1.1

M  +0    -3    applets/taskmanager/package/contents/ui/TaskList.qml
M  +10   -6    applets/taskmanager/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/a1710e8fe0998a737f32158208ab71b20550dc93
Comment 9 Ismael Asensio 2024-06-24 11:04:33 UTC
Git commit 9b85bbab9227c6a988d4293e64f67be04067e2ea by Ismael Asensio.
Committed on 24/06/2024 at 11:04.
Pushed by iasensio into branch 'Plasma/6.1'.

applets/taskmanager: Fix grid layout for forced multiple rows/columns

In the case of forced multiple rows/columns, to calculate the effective
width and height of the TaskList we need to know the exact number of
rows and columns, and also the average occupation of those (fractional
if some rows are not full)
FIXED-IN: 6.1.1


(cherry picked from commit a1710e8fe0998a737f32158208ab71b20550dc93)

M  +0    -3    applets/taskmanager/package/contents/ui/TaskList.qml
M  +10   -6    applets/taskmanager/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/9b85bbab9227c6a988d4293e64f67be04067e2ea