Bug 488594 - Notification body and header have some incorrect paddings now
Summary: Notification body and header have some incorrect paddings now
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-06-16 17:36 UTC by Nate Graham
Modified: 2024-06-19 14:25 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Wrong button positioning (39.43 KB, image/jpeg)
2024-06-16 17:36 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2024-06-16 17:36:59 UTC
Created attachment 170557 [details]
Wrong button positioning

Git master everything, but may affect stable too.

In the headers of notification pop-ups, the close button no longer hugs the right and bottom edges as it used to. Instead the header appears to have become taller, and the button is also offset on the right a little bit.

See attached screenshot.
Comment 1 Nate Graham 2024-06-16 18:03:48 UTC
This was caused by c25acbad5950e089d4c20684fa8d2b5779bce877, which thankfully is master only, not also in stable.

Marco, can you take a look?
Comment 2 David Redondo 2024-06-17 07:23:48 UTC
Confirmed
Comment 3 Bug Janitor Service 2024-06-17 10:39:43 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4462
Comment 4 Nate Graham 2024-06-19 14:25:49 UTC
Git commit 0a11d320dca14cdebc4c3359ab80b6f2768d48d7 by Nate Graham, on behalf of Marco Martin.
Committed on 19/06/2024 at 14:25.
Pushed by ngraham into branch 'master'.

applets/notifications: Re-add headingLeftPadding & headingRightPadding

In order to make the close ToolButton appear without margins, re-add
the properties that were used for this reason in the previous
architecture.

M  +6    -0    applets/notifications/package/contents/ui/NotificationItem.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/0a11d320dca14cdebc4c3359ab80b6f2768d48d7