Bug 488311 - c25acbad5950e089d4c20684fa8d2b5779bce877 makes notification popup height unbounded
Summary: c25acbad5950e089d4c20684fa8d2b5779bce877 makes notification popup height unbo...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-06-10 16:46 UTC by Nate Graham
Modified: 2024-06-16 18:03 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/-/commit/48a778b8348438868f703be82cbe04331226e097
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2024-06-10 16:46:02 UTC 
STEPS TO REPRODUCE
1. In a terminal window, run `notify-send "hi" "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum"`


OBSERVED RESULT
Notification popup is super tall and may even overflow the screen.


EXPECTED RESULT
Notification popup has a bounded height and the absurdly long content scrolls.


ADDITIONAL INFORMATION
Normally you won't see notification text this long, but it's always possible in principle for apps to send super long text. And specifically, it happens due to an unfortunate NeoChat bug: Bug 475228.
Comment 1 Ilya Bizyaev 2024-06-10 16:55:17 UTC 
Happens often with KDE Connect.
Comment 2 Bug Janitor Service 2024-06-11 08:05:36 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4444
Comment 3 Marco Martin 2024-06-11 08:27:26 UTC 
Git commit 48a778b8348438868f703be82cbe04331226e097 by Marco Martin.
Committed on 11/06/2024 at 08:27.
Pushed by mart into branch 'master'.

Restore the maximum height when in popup

Regression fix: when in own popup, cut the notification to a maximum number of lines and
put a scrollbar

M  +1    -1    applets/notifications/package/contents/ui/NotificationItem.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/48a778b8348438868f703be82cbe04331226e097