Bug 482802 - When renaming file or folder on the desktop, the text field can end up smaller than the existing text, possibly letting it become visible
Summary: When renaming file or folder on the desktop, the text field can end up smalle...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: 6.0.1
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
: 484795 487009 487975 491339 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-03-08 02:09 UTC by kimimaru
Modified: 2024-08-10 16:29 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.1.4
Sentry Crash Report:


Attachments
As shown, renaming a folder named "Test" still shows "Test" text, making it hard to see the full name (5.26 KB, image/png)
2024-03-08 02:09 UTC, kimimaru
Details
Shows how the renaming bug looks with Breeze (3.04 KB, image/png)
2024-03-09 01:32 UTC, kimimaru
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kimimaru 2024-03-08 02:09:48 UTC
Created attachment 166666 [details]
As shown, renaming a folder named "Test" still shows "Test" text, making it hard to see the full name

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Create a file or folder on the desktop.
2. Try to rename the file or folder on the desktop (Note: NOT in Dolphin)
3. The existing name of the file or folder will display behind the new name during the process of renaming

OBSERVED RESULT
The existing name of the file or folder displays behind the new name while renaming on the desktop. This makes it very hard to rename files or folders on the desktop.

EXPECTED RESULT
Editing the name of the file or folder on the desktop does not always display the old name behind the existing name.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Arch Linux, kernel 6.7.8-arch1-1 (64-bit)
(available in About System)
KDE Plasma Version: 6.0.1
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2

ADDITIONAL INFORMATION
The issue occurs on both the X11 and Wayland sessions. This seems like a regression from Plasma 5.27 as I haven't had the issue before upgrading.

I'm running this on a laptop with an Intel® Core™ i7-9750H and an NVIDIA GeForce RTX 2060 with proprietary graphics driver version 550.54.14.
Comment 1 Nate Graham 2024-03-08 23:37:07 UTC
It looks like you're using a custom theme. Can you still reproduce the issue with the default Breeze Plasma style?
Comment 2 kimimaru 2024-03-09 01:32:14 UTC
Created attachment 166750 [details]
Shows how the renaming bug looks with Breeze

After switching to Breeze Dark I now see a box covering the old name, which makes it much easier to rename. However, if the old name is two lines long and the new line is one line long, the old name is still visible. IMO I don't see a need to show the old name and don't recall seeing this behavior in Plasma 5.
Comment 3 Nate Graham 2024-03-10 22:29:17 UTC
Can reproduce the issue. Not a Plasma 6 regression; I'm pretty sure it's always been this way.
Comment 4 Nate Graham 2024-06-11 19:44:05 UTC
*** Bug 487975 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2024-07-27 04:46:44 UTC
*** Bug 484795 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2024-07-30 17:39:49 UTC
*** Bug 487009 has been marked as a duplicate of this bug. ***
Comment 7 mozo 2024-07-30 22:46:20 UTC
(In reply to Nate Graham from comment #3)
> Can reproduce the issue. Not a Plasma 6 regression; I'm pretty sure it's
> always been this way.

Nope, it wasn't like that in Plasma 5.
Comment 8 Bug Janitor Service 2024-07-31 21:08:22 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2413
Comment 9 Nate Graham 2024-08-01 00:11:12 UTC
Git commit c1ec86898f49d627d59e9afe5fa14efc49c3f949 by Nate Graham.
Committed on 01/08/2024 at 00:11.
Pushed by ngraham into branch 'master'.

Folder View: hide existing label while renaming

If we don't, it may peek out from behind the text field with the new
name if the user chooses a shorter name, and that looks weird.

This worked in the past but broke with the port to ShadowedLabel, which
disabled the shadow while renaming when it should have hidden itself
completely.
FIXED-IN: 6.1.4

M  +4    -1    containments/desktop/package/contents/ui/FolderItemDelegate.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/c1ec86898f49d627d59e9afe5fa14efc49c3f949
Comment 10 Nate Graham 2024-08-01 00:12:09 UTC
Git commit 3a0cc5449fc36ad9530dd300e8c7d5d2463c4b9b by Nate Graham.
Committed on 01/08/2024 at 00:12.
Pushed by ngraham into branch 'Plasma/6.1'.

Folder View: hide existing label while renaming

If we don't, it may peek out from behind the text field with the new
name if the user chooses a shorter name, and that looks weird.

This worked in the past but broke with the port to ShadowedLabel, which
disabled the shadow while renaming when it should have hidden itself
completely.
FIXED-IN: 6.1.4


(cherry picked from commit c1ec86898f49d627d59e9afe5fa14efc49c3f949)

96fc78bf Folder View: hide existing label while renaming

Co-authored-by: Nate Graham <nate@kde.org>

M  +4    -1    containments/desktop/package/contents/ui/FolderItemDelegate.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/3a0cc5449fc36ad9530dd300e8c7d5d2463c4b9b
Comment 11 Nate Graham 2024-08-10 16:29:01 UTC
*** Bug 491339 has been marked as a duplicate of this bug. ***