Bug 482551 - Error message is cut off
Summary: Error message is cut off
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 6.0.1
Platform: Arch Linux Linux
: HI normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: qt6, regression
: 484512 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-03-06 16:04 UTC by Patrick Silva
Modified: 2024-09-28 10:38 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.2.0
Sentry Crash Report:


Attachments
screenshot (199.88 KB, image/png)
2024-03-06 16:04 UTC, Patrick Silva
Details
screenshot of Discover 6.1.3 (287.54 KB, image/png)
2024-07-31 15:46 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2024-03-06 16:04:03 UTC
Created attachment 166482 [details]
screenshot

STEPS TO REPRODUCE
1. open Discover
2. click on an installed app
3. click on "Launch" button in the upper right corner

OBSERVED RESULT
As we can see in the attached screenshot, sometimes an error message from Discover is cut off.

EXPECTED RESULT
entirely readable error message

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.0.1
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Graphics Platform: Wayland
Comment 1 Nate Graham 2024-03-06 20:03:25 UTC
I was able to make this error dialog appear by creating a desktop file for an installed app in ~/.local/share/applications with a malformed Exec line and then launching that app from Discover, but I haven't been able to reproduce the problem of it being partially cut off like this.
Comment 2 Patrick Silva 2024-07-31 15:30:55 UTC
*** Bug 484512 has been marked as a duplicate of this bug. ***
Comment 3 Patrick Silva 2024-07-31 15:46:10 UTC
Created attachment 172147 [details]
screenshot of Discover 6.1.3

Another way to reproduce on Arch Linux:

1. run "sudo pacman -Syu" when updates are available, but do not install anything
2. open Discover while pacman is waiting for an answer to install or not the available updates

Result: Discover shows the warning with broken layout seen in the screenshot attached to this comment.

Operating System: Arch Linux 
KDE Plasma Version: 6.1.3
KDE Frameworks Version: 6.4.0
Qt Version: 6.7.2
Graphics Platform: Wayland
Comment 4 Nate Graham 2024-09-24 13:13:08 UTC
Will be fixed with https://invent.kde.org/plasma/discover/-/merge_requests/937!
Comment 5 Akseli Lahtinen 2024-09-26 10:14:06 UTC
Git commit fcb723d3b988b9afdfe97a884b16ad8736916943 by Akseli Lahtinen.
Committed on 26/09/2024 at 10:14.
Pushed by akselmo into branch 'master'.

DiscoverWindow.qml: Port message OverlaySheet to Dialog and make it friendlier

Currently the passiveMessage dialog in DiscoverWindow is a bit too in-your-face with the errors, causing sadness and confusion with users.
It also used Kirigami.OverlaySheet even it is more of a dialog.

This MR makes it use Kirigami.Dialog features and hides the technical details behind a button, plus gives it a friendlier message.
Related: bug 468657
FIXED-IN: 6.2.0

M  +49   -50   discover/qml/DiscoverWindow.qml

https://invent.kde.org/plasma/discover/-/commit/fcb723d3b988b9afdfe97a884b16ad8736916943
Comment 6 Akseli Lahtinen 2024-09-26 12:10:05 UTC
Git commit ffd87c84563e4dd30d125065ac1ab4f1a8517801 by Akseli Lahtinen.
Committed on 26/09/2024 at 12:05.
Pushed by akselmo into branch 'Plasma/6.2'.

DiscoverWindow.qml: Port message OverlaySheet to Dialog and make it friendlier

Currently the passiveMessage dialog in DiscoverWindow is a bit too in-your-face with the errors, causing sadness and confusion with users.
It also used Kirigami.OverlaySheet even it is more of a dialog.

This MR makes it use Kirigami.Dialog features and hides the technical details behind a button, plus gives it a friendlier message.
Related: bug 468657
FIXED-IN: 6.2.0


(cherry picked from commit fcb723d3b988b9afdfe97a884b16ad8736916943)

ea6a8f09 Move buttons to footer
9be1e908 Hide technical details under friendly message
0506fc4b Format
7a1835d0 change overlaysheet to dialog
1b8bc04d Use more reasonable preferred size
dd6ec741 Add padding
c596e6a0 Change message to be more generic
42924901 Use customFooterActions
bb0826c6 Cleanups
6ad94806 Revert some formatter stuff
c951839b Remove leftovers from overlaysheet changes

Co-authored-by: Akseli Lahtinen <akselmo@akselmo.dev>

M  +49   -50   discover/qml/DiscoverWindow.qml

https://invent.kde.org/plasma/discover/-/commit/ffd87c84563e4dd30d125065ac1ab4f1a8517801