Bug 480044 - When in edit mode, choosing exit edit mode from a second panel does not exit edit mode
Summary: When in edit mode, choosing exit edit mode from a second panel does not exit ...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: master
Platform: openSUSE Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
: 481743 481826 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-01-19 13:00 UTC by Mike
Modified: 2024-02-25 19:43 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike 2024-01-19 13:00:39 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1.  Enter desktop edit mode, either from context menu or a panel context
2.  From another panel context menu, choose exit edit mode

OBSERVED RESULT
You will still be in edit mode

EXPECTED RESULT
You should have exited edit mode

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
CCBUG: 449004
Comment 1 Bug Janitor Service 2024-01-23 14:29:56 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3813
Comment 2 Marco Martin 2024-01-29 10:11:14 UTC
Git commit 5a8a53ff328493ff14ca79d456fdb419ba1d6e7d by Marco Martin.
Committed on 29/01/2024 at 10:11.
Pushed by mart into branch 'master'.

Less confusing messages for the panel configuration

right now the context menu entry of the panel is "enter edit mode" or
"exit edit mode" when global edit mode is on.

However, that action does *not* exit edit mode, but it actually opens
the panel config views when is not visible (for instance a secondary
panel)

when the config view is visible in theory that action is supposed to go
out of edit mode, howeverthere isn't really a way to trigger the action
when the panel edit window is open at the moment

Changing to Show Panel Configuration makes the ui much less confusing
as it actually does what the label says now

M  +20   -0    shell/panelview.cpp
M  +1    -0    shell/panelview.h

https://invent.kde.org/plasma/plasma-workspace/-/commit/5a8a53ff328493ff14ca79d456fdb419ba1d6e7d
Comment 3 Marco Martin 2024-01-29 14:27:40 UTC
The problem was actually a wrong messaging from the action, because is not "supposed" to exit edit mode.

In Plasma 6.1 the messaging will be "Open Panel Configuration" "Close Panel Configuration"
Comment 4 fanzhuyifan 2024-02-24 03:50:33 UTC
*** Bug 481743 has been marked as a duplicate of this bug. ***
Comment 5 fanzhuyifan 2024-02-25 19:43:35 UTC
*** Bug 481826 has been marked as a duplicate of this bug. ***