Bug 479755 - [Wayland] Invisible icons/texts in the logout screen if an icc color profile is used
Summary: [Wayland] Invisible icons/texts in the logout screen if an icc color profile ...
Status: ASSIGNED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: 5.92.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Nate Graham
URL:
Keywords: qt6, wayland
: 480419 482793 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-01-13 17:57 UTC by Patrick Silva
Modified: 2024-07-16 11:03 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
icc color profile (8.33 KB, application/vnd.iccprofile)
2024-01-13 17:57 UTC, Patrick Silva
Details
screenshot of the logout screen (146.52 KB, image/png)
2024-01-13 17:57 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2024-01-13 17:57:12 UTC
Created attachment 164873 [details]
icc color profile

SUMMARY
Can reproduce on Wayland, cannot on X11.

STEPS TO REPRODUCE
1. use Wayland
2. apply the attached icc color profile in Display Configuration KCM
3. make sure logout screen is activated in Desktop Session KCM
4. right-click on desktop and choose "Leave..."

OBSERVED RESULT
invisible icons/texts in the logout screen, as we can see in the attached screenshot

EXPECTED RESULT
all texts/icons with normal visibility

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.92.0
KDE Frameworks Version: 5.248.0
Qt Version: 6.7.0
Graphics Platform: Wayland
Comment 1 Patrick Silva 2024-01-13 17:57:34 UTC
Created attachment 164874 [details]
screenshot of the logout screen
Comment 2 Zamundaaa 2024-01-22 23:22:52 UTC
To be honest, looking at the code of the logout greeter, I don't know how it chooses its colors - text and icons are always white for me, independently of what the colorscheme says? This is the case for me on Plasma 5 at least, it doesn't work at all for me on 6 so it's hard to test.

What I do know though is that it has 50% translucent text+icons on top of a 50% translucent background window. The first 50% are always being blended in gamma 2.2 space, but the second one is gamma 2.2 without color management, and linear with color management.
So if the background is black, the background window is black and the text is 100% white, the first blending step brings the text down to 50% brightness, and the second
- without color management: to 25%
- with color management: to 11%
(assuming a perfectly black background). The difference in readability should be obvious - though the state without color management is also not good by any means.

So I think this has to be fixed here in the logout greeter - ideally by not relying on opacity to signal focus in the first place. Perhaps it can be aligned more to how focus is shown everywhere else?
Comment 3 Nate Graham 2024-01-24 22:46:33 UTC
Good idea. I'll see what I can do.
Comment 4 Nate Graham 2024-01-25 04:57:08 UTC
It turns out that "everywhere" is a relative term; these round opacity-based buttons are used on the login, lock, and logout screens. So if we change them in one, we ought to change the others too. I'll see if I can work up something that uses more standard-style buttons while still looking good in these contexts, and avoiding the need to totally redesign all of them to compensate.
Comment 5 Nate Graham 2024-02-07 17:34:47 UTC
*** Bug 480419 has been marked as a duplicate of this bug. ***
Comment 6 Bug Janitor Service 2024-03-07 00:55:56 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4010
Comment 7 panorain 2024-03-07 01:04:24 UTC
For my situation with blank SDDM was create /etc/environment then enable software rendering QT_QUICK_BACKEND=software

https://gitlab.freedesktop.org/mesa/mesa/-/issues/10523#note_2304029

If it helps any.
Comment 8 Nate Graham 2024-03-10 20:04:34 UTC
*** Bug 482793 has been marked as a duplicate of this bug. ***
Comment 9 Bug Janitor Service 2024-07-04 17:43:21 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/6050
Comment 10 Zamundaaa 2024-07-05 14:45:50 UTC
Git commit f20ccabe80c056066f556f9f7f23b253e4704b43 by Xaver Hugl.
Committed on 05/07/2024 at 12:52.
Pushed by zamundaaa into branch 'master'.

backends/drm: do blending in gamma 2.2 space with color management too

This matches what we do without color management, and is more what users and app
developers expect. Going with linear blending before was mostly from it being more
"correct" / how physical blending of light works, but that doesn't really matter
when existing software expects it to behave differently.
Related: bug 476868

M  +1    -1    src/backends/drm/drm_egl_layer_surface.cpp

https://invent.kde.org/plasma/kwin/-/commit/f20ccabe80c056066f556f9f7f23b253e4704b43
Comment 11 Bug Janitor Service 2024-07-13 03:00:24 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4515