Bug 479592 - Clicking on a song in Tracks view adds the whole content of the view to the playlist
Summary: Clicking on a song in Tracks view adds the whole content of the view to the p...
Status: CONFIRMED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 23.08.4
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords: usability
: 480778 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-01-10 03:03 UTC by Kevin Kofler
Modified: 2024-02-06 22:04 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Kofler 2024-01-10 03:03:54 UTC
SUMMARY
In the track view, if I touch (on mobile) a song, I would expect it to play just that one song. (Whether it enqueues it or replaces the playlist with it is up for debate, and IMHO it should be configurable.) Unfortunately, what the touch does instead is that it replaces the playlist with the entire contents of the track view! If I have not done a search, this means it adds every single song in my collection to the playlist! Obviously, this is NOT what I want.

Enqueuing the whole album MIGHT make sense for the album view, but for the track view, the touch should really only add that one track.

STEPS TO REPRODUCE
1. Start Elisa on Plasma Mobile (though the behavior is probably the same on desktop).
2. Open the Tracks view if not already opened.
3. Touch / click on a track.

OBSERVED RESULT
The entire contents of the Track view are added to the playlist, replacing its existing contents. If I have not done a search, this means it adds every single song in my collection to the playlist! (And it does not even jump to that song in the playlist, but just starts from the top, which is probably a bug, but it would not happen if it were not behaving that weirdly in the first place.) Even when I do a search, I am going to stop typing once I see the song I am looking for and do not want to enqueue any other songs that happen to match the substring I am searching for.

EXPECTED RESULT
The one song that I touched / clicked on (and only that one song!) is added to the playlist. Either it replaces the existing playlist contents, or it is appended to it, the other option should be available from the "..." menu. But in no event should it add the entire contents of the Tracks view.

SOFTWARE/OS VERSIONS
Hardware: PINE64 PinePhone (original Allwinner A64 model, Beta Edition with
Convergence Package (dock not plugged in))
Linux/KDE Plasma: Manjaro ARM (Plasma Mobile Edition, aarch64)
KDE Plasma Version: 5.27.10
KDE Frameworks Version: 5.113.0
Qt Version: 5.15.11 with KDE patches
Elisa Version: 23.08.4 (elisa-qtmm 23.08.4-1)

ADDITIONAL INFORMATION
The confusing behavior was introduced by commits:
https://invent.kde.org/multimedia/elisa/-/commit/bcc52c704cc929c35109f4bc80834e48607e2a6a
https://invent.kde.org/multimedia/elisa/-/commit/ebd0673ec741c4710c82a86cf1cd62c15bbfaf64
See bug #406469.

The workaround is to use the … button and the enqueue option. But that popup is missing a replace / play now option, so if I want that, I have to first empty the playlist, then use "Add to queue", and then play. So I have to do 6 touches (open the playlist, empty it, close it, open the … menu, enqueue, play) instead of the 1 I am used to, or at least only 2 as I suggest (open the … menu, "Replace playlist and play now"). I hope you agree that this is a usability regression.
Comment 1 Nate Graham 2024-01-10 17:02:17 UTC
We could make it configurable, or we could add an exception to the current behavior for just the Tracks view, where I agree that it doesn't make much sense.
Comment 2 Fotios Valasiadis 2024-01-29 02:39:30 UTC
(In reply to Nate Graham from comment #1)
> We could make it configurable, or we could add an exception to the current
> behavior for just the Tracks view, where I agree that it doesn't make much
> sense.

I was about to submit a bug before finding this post. The exact same behavior is observed in the desktop app as well. Clicking play on any track from the "Tracks" view (which literally if you hover over the play button, there is a tooltip saying "Play from here, replacing current playlist") instead loads all the playlist and starts playing top to bottom.
Comment 3 Nate Graham 2024-02-06 22:04:51 UTC
*** Bug 480778 has been marked as a duplicate of this bug. ***