Bug 467903 - Datebar sometimes grays out non-empty units
Summary: Datebar sometimes grays out non-empty units
Status: RESOLVED FIXED
Alias: None
Product: kphotoalbum
Classification: Applications
Component: Datebar (show other bugs)
Version: 5.10.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: KPhotoAlbum Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-28 23:19 UTC by Johannes Zarl-Zierl
Modified: 2023-04-01 20:03 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
unit <= minUnit (164.91 KB, image/jpeg)
2023-03-29 07:41 UTC, Pierre Etchemaïté
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Zarl-Zierl 2023-03-28 23:19:56 UTC
SUMMARY

As pointed out by Pierre Etchemaïté at https://invent.kde.org/graphics/kphotoalbum/-/commit/2d5b87c0430a791b4afb3a660bef923464d5376f#note_650503, the algorithm for graying out the empty margin areas of the DateBar can sometimes gray out non-empty time units.
Comment 1 Pierre Etchemaïté 2023-03-29 07:41:40 UTC
Created attachment 157681 [details]
unit <= minUnit

Thanks for creating the bug report!
Oldest picture in the selection is dated 08:39 something, but 08:00-09:59 unit is grayed when it shouldn't
Comment 2 Johannes Zarl-Zierl 2023-04-01 19:52:15 UTC
The fix for the real bug is not immediately obvious. I've created a new bug report specifically for that issue (see bug #468045), so that I don't have to delay fixing your issue until I found the other issue...
Comment 3 Johannes Zarl-Zierl 2023-04-01 20:03:52 UTC
Git commit 5b4329f99347b80bb748f2e6c49b3d3dd14d8c3a by Johannes Zarl-Zierl.
Committed on 01/04/2023 at 20:01.
Pushed by johanneszarl into branch 'master'.

Fix incorrectly greyed out time slots in the date bar

The bug was introduced because the date bar incorrectly shows an image
count of 0 for the year 1988 in the demo database. This separate issue
is tracked in the bug #468045.

M  +1    -0    CHANGELOG.md
M  +6    -6    DateBar/DateBarWidget.cpp

https://invent.kde.org/graphics/kphotoalbum/commit/5b4329f99347b80bb748f2e6c49b3d3dd14d8c3a