Bug 468045 - DateBar selection of time-units imprecise
Summary: DateBar selection of time-units imprecise
Status: RESOLVED FIXED
Alias: None
Product: kphotoalbum
Classification: Applications
Component: Datebar (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: KPhotoAlbum Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-01 19:49 UTC by Johannes Zarl-Zierl
Modified: 2023-04-03 22:29 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Zarl-Zierl 2023-04-01 19:49:13 UTC
SUMMARY

It seems that images with fuzzy dates sometimes are presented incorrectly when using the date bar:
Fuzzy dates are not always correctly counted in the datebar, and selecting a time range sometimes selects additional images.

STEPS TO REPRODUCE
1. Open kphotoalbum demo database
2. Move the mouse cursor to the date bar over the year 1988 and note the text in the status bar: "1988 | 0 images/videos"
3. Click the date bar below the year 1988 to limit the time range to the year 1988
4. Click "Show Thumbnails..."

OBSERVED RESULT
The following two images are shown:
 - "new_wave_2.jpg," with the fuzzy date 1988-1990
 - "new_wave_1.jpg", with the fuzzy date 1989-1990

EXPECTED RESULT
A single image, "new_wave_2.jpg" and an image count of 1 fuzzy image for the year 1988.
Comment 1 Johannes Zarl-Zierl 2023-04-02 22:53:17 UTC
Git commit d5179c263ac52bd9b30b1f28c91488a163627fda by Johannes Zarl-Zierl.
Committed on 02/04/2023 at 22:43.
Pushed by johanneszarl into branch 'master'.

Fix image count in DateBar

When counting images, the earliest starting of two time ranges with the
same end time was skipped, leading to an image count that was too low.
This bug is easily demonstrated using the demo database, as seen in
the linked bug report.

Also, images with a start date that is exactly the same as the end of
the time range would be ignored. This bug may be triggered by an image
with a non-fuzzy date that was shot exactly on Dec. 31st at 23:59:59
when having the datebar units set to years.

M  +5    -4    XMLDB/XMLImageDateCollection.cpp

https://invent.kde.org/graphics/kphotoalbum/commit/d5179c263ac52bd9b30b1f28c91488a163627fda
Comment 2 Johannes Zarl-Zierl 2023-04-03 22:24:31 UTC
Git commit 58eafdf7af84d5efeb538a5b3ab541d560e8bfa8 by Johannes Zarl-Zierl.
Committed on 03/04/2023 at 22:19.
Pushed by johanneszarl into branch 'master'.

Fix date range for selection via DateBar

Selecting a date range via the DateBar incorrectly included the begin of
the following time unit when it shouldn't. I.e. selecting a year like
1988 by clicking below it on the DateBar selected the range
1988-01-01T00:00:00 - 1989-01-01T00:00:00 instead of
1988-01-01T00:00:00 - 1988-12-31T23:59:59.

M  +6    -5    DateBar/MouseHandler.cpp

https://invent.kde.org/graphics/kphotoalbum/commit/58eafdf7af84d5efeb538a5b3ab541d560e8bfa8