Bug 467004 - Application Launcher icon ridiculously large in thick panel
Summary: Application Launcher icon ridiculously large in thick panel
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: 5.27.2
Platform: Other Linux
: HI normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
: 466566 467716 478947 486509 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-03-07 11:54 UTC by Tristan Miller
Modified: 2024-05-26 15:47 UTC (History)
11 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/-/commit/d7e8d047e29aa16e1848076b1136e4997d33298d
Version Fixed In: 6.0.5
Sentry Crash Report:

Attachments
Screenshot showing ridiculously large Application Launcher icon (36.91 KB, image/png)
2023-03-07 11:54 UTC, Tristan Miller 		Details
Screenshot of a widget (67.31 KB, image/png)
2024-04-26 10:49 UTC, Eugene Savitsky 		Details
Comparance - 6.0.4 vs 6.0.5 (202.99 KB, image/png)
2024-05-26 15:44 UTC, Eugene Savitsky 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Tristan Miller 2023-03-07 11:54:58 UTC 
Created attachment 157081 [details]
Screenshot showing ridiculously large Application Launcher icon

I upgraded today from Plasma 5.26.5 to 5.27.2.  The Application Launcher icon in my vertical panel now takes up the full width of the panel, whereas before the upgrade it was only a few dozen pixels wide.  The new size is far too large -- see attached screenshot.

STEPS TO REPRODUCE
1. Add a vertical panel with a width of, say, 256 pixels.
2. Add the Application Launcher to the panel.

OBSERVED RESULT
1. The Application Launcher icon is ridiculously large, spanning the full width of the panel, and taking up too much vertical space.

EXPECTED RESULT
1. The Application Launcher icon should be the same size as the application icons it contains.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 5.27.2
KDE Plasma Version: 5.27.2
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Comment 1 Tristan Miller 2023-03-08 09:48:43 UTC 
Is this bug perhaps a consequence of either of the following recent commits?

* applets/kickoff: fix: height larger than previous version in vertical panel: https://github.com/KDE/plasma-desktop/commit/1988f0756ec9b61d6eff6eae14c1023502d7f701
* [kicker, kickoff] Port away from panel icon size hint: https://github.com/KDE/plasma-desktop/commit/277758af8c3f701c92f0b77aa8ecfc8d07ab9ac9
Comment 2 Nate Graham 2023-03-08 14:47:36 UTC 

*** This bug has been marked as a duplicate of bug 466566 ***
Comment 3 Nate Graham 2024-03-07 19:13:19 UTC 
Screw it, let's just revert this change for Kickoff since it's the only widget people actually care about being too big, and we're not even consistent about everything being too big in the same way anyway, so there's no philosophical justification to continuing it.
Comment 4 Nate Graham 2024-03-07 19:13:34 UTC 
*** Bug 467716 has been marked as a duplicate of this bug. ***
Comment 5 Nate Graham 2024-03-07 19:13:54 UTC 
*** Bug 477813 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2024-03-07 19:15:34 UTC 
*** Bug 482612 has been marked as a duplicate of this bug. ***
Comment 7 Nate Graham 2024-03-07 19:15:59 UTC 
*** Bug 478947 has been marked as a duplicate of this bug. ***
Comment 8 Nate Graham 2024-03-07 19:16:41 UTC 
*** Bug 466566 has been marked as a duplicate of this bug. ***
Comment 9 Eugene Savitsky 2024-03-08 10:07:06 UTC 
Actually I have the same problem with KDE 5.27.x (as with 6.x). Start button and Weather widgets are same huge.
Comment 10 andy 2024-03-08 15:24:35 UTC 
(In reply to ezh from comment #9)
> Actually I have the same problem with KDE 5.27.x (as with 6.x). Start button
> and Weather widgets are same huge.

yeah I think I it depends which kicker alternative you use, or which specific widget

For example Application Launcher is huge, but Application Dashboard and Application Menu are fixed by tweaking the size hints in org.kde.plasma.kicker/contents/ui/CompactRepresentation.qml (https://bugs.kde.org/show_bug.cgi?id=466566#c19)
Comment 11 andy 2024-03-08 15:28:34 UTC 
(In reply to Nate Graham from comment #3)
> Screw it, let's just revert this change for Kickoff 

Also Kicker? to cover the 3 alternatives. The size hints in  org.kde.plasma.kicker/contents/ui/CompactRepresentation.qml affect Application Dashboard and Application Menu's icon size, but not Application Launcher (kickoff)
Comment 12 andy 2024-03-11 19:51:02 UTC 
related https://bugs.kde.org/show_bug.cgi?id=483274
extra huge tray icons with vertical panel: https://bugsfiles.kde.org/attachment.cgi?id=166977
Comment 13 PRIZ ;] 2024-03-12 17:05:34 UTC 
(In reply to andy from comment #12)
> related https://bugs.kde.org/show_bug.cgi?id=483274
> extra huge tray icons with vertical panel:
> https://bugsfiles.kde.org/attachment.cgi?id=166977

That isn't a bug (as of Plasma 5.27.10).
Configure System Tray Settings > Panel Size Icon > Small
Comment 14 Nate Graham 2024-03-13 16:26:13 UTC 
Tray icons are unrelated here, and what you're seeing is currently intentional when in Touch Mode.

That can be reconsidered too, but it would need a separate bug report.
Comment 15 Ben 2024-04-19 02:38:26 UTC 
Can confirm this is still an issue in Plasma 6.0.4 with Frameworks version 6.1.0.
Comment 16 andy 2024-04-26 04:31:29 UTC 
I'm still using this post-install to fix it (currently plasma 6.0.3 and frameworks 6.1.0, arch linux)

sed -i 's/root.Layout.minimumWidth = -1;/root.Layout.minimumWidth = -1; root.Layout.maximumWidth = 30;/g' /usr/share/plasma/plasmoids/org.kde.plasma.kicker/contents/ui/CompactRepresentation.qml
sed -i 's/root.Layout.minimumHeight = -1;/root.Layout.minimumHeight = -1; root.Layout.maximumHeight = 30;/g' /usr/share/plasma/plasmoids/org.kde.plasma.kicker/contents/ui/CompactRepresentation.qml
Comment 17 Eugene Savitsky 2024-04-26 10:49:25 UTC 
Created attachment 168914 [details]
Screenshot of a widget

Not only the "Start" button is huge, all other applets are as well. See screenshot.
Comment 18 Nate Graham 2024-04-26 13:32:05 UTC 
So basically here's the situation.

In the past we had a global "Panel icon size" setting that controlled the maximum size that icons can grow to across all Plasma panels. This presented some issues:
1. It was not presented as a maximum size, so people would adjust it, see that nothing happened, and get confused.
2. Not all widgets respected it, so even if you did have a thick panel, its effects often seemed random.
3. It was global in scope, when in principle it makes sense to be a panel-specific setting because not all panels are thick enough for the setting to be applicable.

1 and 2 were theoretically fixable using the existing infrastructure, but 3 was not. For these reasons, we deleted the setting late in Plasma 6, and deleted the backend code that it controlled in Plasma 6. Instead, all widgets scale with the panel thickness.

This presents new issues:
1. Not all widgets do this! So sizing still feels random.
2. People with very thick panels who don't want their panel icons to be so huge no longer have a way to make that happen.

Short term, this bug report proposes capping the maximum size of just Kickoff, since it's the thing people are complaining most about.

Medium term, I think we should probably re-add a maximum icon size setting, but make it panel-specific, and then also put in the work to port *every* widget to use it, so that it doesn't feel random.
Comment 19 Bug Janitor Service 2024-04-30 14:52:46 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2231
Comment 20 Akseli Lahtinen 2024-05-01 14:19:32 UTC 
Git commit 61fb4a6296cb1f5ff5de975bd6f128b1f0d4bc71 by Akseli Lahtinen.
Committed on 01/05/2024 at 14:19.
Pushed by akselmo into branch 'master'.

kickoff: Use Kirigami.Units.iconSizes.huge as maximum icon size

This avoids having ridiculously large icon size as a short term solution.

M  +2    -0    applets/kickoff/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/61fb4a6296cb1f5ff5de975bd6f128b1f0d4bc71
Comment 21 Akseli Lahtinen 2024-05-01 14:26:41 UTC 
Git commit d7e8d047e29aa16e1848076b1136e4997d33298d by Akseli Lahtinen.
Committed on 01/05/2024 at 14:19.
Pushed by akselmo into branch 'Plasma/6.0'.

kickoff: Use Kirigami.Units.iconSizes.huge as maximum icon size

This avoids having ridiculously large icon size as a short term solution.


(cherry picked from commit 61fb4a6296cb1f5ff5de975bd6f128b1f0d4bc71)

5ac00133 kickoff: Use Kirigami.Units.iconSizes.huge as maximum icon size

M  +2    -0    applets/kickoff/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/d7e8d047e29aa16e1848076b1136e4997d33298d
Comment 22 Ben 2024-05-01 14:32:50 UTC 
My original bug report for Kicker got marked as a duplicate of this one.  Is there any chance for a Kicker fix as well?
Comment 23 Nate Graham 2024-05-01 20:40:40 UTC 
Yes, I'll un-dupe it and fix that as well.
Comment 24 Nate Graham 2024-05-01 21:03:22 UTC 
Kicker is done in https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2234.
Comment 25 Nate Graham 2024-05-03 19:16:12 UTC 
*** Bug 486509 has been marked as a duplicate of this bug. ***
Comment 26 Eugene Savitsky 2024-05-06 15:31:42 UTC 
Using KDE Neon Unstable on a testing notebook I still see huge start icon...
Comment 27 Nate Graham 2024-05-06 19:51:43 UTC 
Then Neon's packages must be running a little bit behind.
Comment 28 Eugene Savitsky 2024-05-26 15:44:53 UTC 
Created attachment 169852 [details]
Comparance - 6.0.4 vs 6.0.5

Got KDE 6.0.5 on Fedora 40. The Launcher icon is now a bit smaller, but still huge.
Comment 29 Nate Graham 2024-05-26 15:47:26 UTC 
So is your weather icon.

I'm afraid that's the best we can do for now until we implement a per-panel maximum icon size feature.