Bug 465796 - Clicking on screenshot to open large version does not steal keyboard navigation from app page
Summary: Clicking on screenshot to open large version does not steal keyboard navigati...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.27.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: accessibility, usability
Depends on:
Blocks:
 
Reported: 2023-02-15 22:57 UTC by Jack Hill
Modified: 2023-10-26 22:31 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jack Hill 2023-02-15 22:57:08 UTC
SUMMARY


STEPS TO REPRODUCE
1. Open an app with an app page with an image gallery (e.g. GCompris)
2. Press tab until the "Install" button is highlighted
3. Press tab once more, and press enter (the first image preview should be opened now)
4. Keep pressing tab until the "Install" button is highlighted again (image preview should still be open)
5. Press enter

OBSERVED RESULT
The app starts installing, even though the image preview is in focus.

EXPECTED RESULT
The image preview should prevent the app page from taking keyboard focus, i.e. should not be able to reach the "Install" button

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20230213
KDE Plasma Version: 5.27.0
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Kernel Version: 6.1.10-1-default (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
Comment 1 ratijas 2023-10-26 16:32:17 UTC
Git commit ef687b397b95ef3530f780c236fc3fe7a64d12f6 by ivan tkachenko.
Committed on 26/10/2023 at 17:49.
Pushed by ratijas into branch 'master'.

carousel: Implement FullScreen and Overlay views

Current index is synchronized between views, with "other" view updating
without animations. Both overlays (native window and in-scene popup)
are self-destructible on close. Animated gifs are auto-playing when
maximizing, and stop playing when current index changes away from them.
Play/Pause button reacts on mouse move, and auto-hides after a brief
timeout.
Related: bug 433321, bug 465794, bug 455304, bug 444103

M  +60   -33   discover/qml/CarouselDelegate.qml
M  +1    -0    discover/qml/CarouselFullScreenMaximizedView.qml
M  +8    -1    discover/qml/CarouselInlineView.qml
M  +101  -6    discover/qml/CarouselMaximizedViewContent.qml
M  +1    -0    discover/qml/CarouselOverlayMaximizedView.qml
M  +1    -0    discover/qml/CarouselPageIndicator.qml

https://invent.kde.org/plasma/discover/-/commit/ef687b397b95ef3530f780c236fc3fe7a64d12f6