Bug 433321 - Arrows of screenshots gallery don't always work
Summary: Arrows of screenshots gallery don't always work
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.26.90
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-02-20 12:02 UTC by Patrick Silva
Modified: 2023-10-26 22:31 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0
Sentry Crash Report:


Attachments
screen recording (3.14 MB, video/webm)
2021-02-20 12:02 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2021-02-20 12:02:32 UTC
Created attachment 135963 [details]
screen recording

Title says it all. Watch the attached screen recording please.

Operating System: Arch Linux
KDE Plasma Version: 5.21.0
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Graphics Platform: X11
Comment 1 Nate Graham 2021-02-22 00:59:24 UTC
What's going on here is that the arrow internally, invisibly selects the next screenshot rather than scrolling. If the next screenshot is capable of being selected without scrolling because it is already visible, the view will not scroll.

The arrows should always scroll rather than changing the index of which screenshot is selected.
Comment 2 nttkde 2021-03-05 23:15:04 UTC
-Also, optimally, the arrows should take the screenshot gallery(/window) width into account and hide when it's wide enough to show all screenshots at once 
(as the arrows are then unnecessary and obviously won't do anything when user clicks on them).
Currently, the logic seems to be the arrows are hidden when there is only one screenshot.
On the other hand, the horizontal gallery scrollbar does hide correctly based on gallery width.

-And the current way it works, as Nate said, causes also another bug; 
the arrows aren't affected by the horizontal gallery scrollbar.
If I drag the scrollbar to the right side and then press the right arrow, it'll jump back to the second screenshot from the start.
Comment 3 ratijas 2023-10-26 16:32:41 UTC
Git commit ef687b397b95ef3530f780c236fc3fe7a64d12f6 by ivan tkachenko.
Committed on 26/10/2023 at 17:49.
Pushed by ratijas into branch 'master'.

carousel: Implement FullScreen and Overlay views

Current index is synchronized between views, with "other" view updating
without animations. Both overlays (native window and in-scene popup)
are self-destructible on close. Animated gifs are auto-playing when
maximizing, and stop playing when current index changes away from them.
Play/Pause button reacts on mouse move, and auto-hides after a brief
timeout.
Related: bug 465794, bug 465796, bug 455304, bug 444103

M  +60   -33   discover/qml/CarouselDelegate.qml
M  +1    -0    discover/qml/CarouselFullScreenMaximizedView.qml
M  +8    -1    discover/qml/CarouselInlineView.qml
M  +101  -6    discover/qml/CarouselMaximizedViewContent.qml
M  +1    -0    discover/qml/CarouselOverlayMaximizedView.qml
M  +1    -0    discover/qml/CarouselPageIndicator.qml

https://invent.kde.org/plasma/discover/-/commit/ef687b397b95ef3530f780c236fc3fe7a64d12f6