Bug 465281 - CPU percentage sign is not localisable
Summary: CPU percentage sign is not localisable
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: git-stable-Plasma/5.26
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-04 17:30 UTC by Emir SARI
Modified: 2023-02-11 03:37 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emir SARI 2023-02-04 17:30:07 UTC
SUMMARY

On the main System Monitor page, the CPU percentage indicator is hardcoded, always following the value. It should be localisable to accommodate languages that have different formatting for percentages.
Comment 1 Arjen Hiemstra 2023-02-07 13:09:31 UTC
The values are passed through libksysguard's Formatter for formatting, which does have localisation support: https://invent.kde.org/plasma/libksysguard/-/blob/master/formatter/Formatter.cpp#L61
Comment 2 Emir SARI 2023-02-07 16:38:04 UTC
Looks like the same issue with #465282. I am unable to find the strings in SVN.
Comment 3 Bug Janitor Service 2023-02-08 09:43:15 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/256
Comment 4 Arjen Hiemstra 2023-02-10 11:22:36 UTC
Git commit d33fe297ec4a52da0c4978e58996334b26414620 by Arjen Hiemstra.
Committed on 10/02/2023 at 11:20.
Pushed by ahiemstra into branch 'master'.

formatter: Properly extract strings to a translation catalog

Apparently we forgot this
Related: bug 465282

M  +2    -0    formatter/CMakeLists.txt
A  +2    -0    formatter/Messages.sh

https://invent.kde.org/plasma/libksysguard/commit/d33fe297ec4a52da0c4978e58996334b26414620
Comment 5 Arjen Hiemstra 2023-02-10 12:03:18 UTC
Git commit 68679d8ada54dfac5ce12491324f91d8572b789c by Arjen Hiemstra.
Committed on 10/02/2023 at 12:03.
Pushed by ahiemstra into branch 'Plasma/5.27'.

formatter: Properly extract strings to a translation catalog

Apparently we forgot this
Related: bug 465282


(cherry picked from commit d33fe297ec4a52da0c4978e58996334b26414620)

M  +2    -0    formatter/CMakeLists.txt
A  +2    -0    formatter/Messages.sh

https://invent.kde.org/plasma/libksysguard/commit/68679d8ada54dfac5ce12491324f91d8572b789c