Bug 460661 - In overview effect, Virtual Desktops' spatial arrangement is preserved from the perspective of using the desktop switching shortcuts, but a flattened arrangement is shown visually
Summary: In overview effect, Virtual Desktops' spatial arrangement is preserved from t...
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-overview (show other bugs)
Version: 5.26.0
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2022-10-18 14:24 UTC by postix
Modified: 2023-09-25 11:15 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/kwin/-/commit/028dd552cfb9d826b40b9620d869c98d2aa3dca3
Version Fixed In: 6.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2022-10-18 14:24:15 UTC 
STEPS TO REPRODUCE
1. 2x2 grid of virtual desktops
2. Open the overview effect
3. Press Ctrl+Meta+Right/Left

OBSERVED RESULT
The overview effect shows the 2x2 grid as a 4x1 array.
Pressing  Ctrl+Meta+Right/Left lets you move only between 1 <---> 2, to go to VD 3 or 4 you need to press arrow key down first.

EXPECTED RESULT
Since the desktops are displayed as a flat array, it'd be logical to reach them all by Modifier+left/right key presses only.


SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20221016
KDE Plasma Version: 5.26.0
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.6
Kernel Version: 6.0.1-1-default (64-bit)
Graphics Platform: Wayland
Comment 1 Nate Graham 2022-10-18 19:27:34 UTC 
Ideally we would just show them in their true arrangement IMO.
Comment 2 postix 2022-10-20 12:38:46 UTC 
(In reply to Nate Graham from comment #1)
> Ideally we would just show them in their true arrangement IMO.

The big question is, how an arbitrary arrangement should be displayed, considering that it requires some more screen space than the current solution.

If you are fine with it, I'd go with the flat arrangement and adjusted hot-key-controls first, because that's a quicker solution, until the other problem is solved. 
If a patch were proposed, would it go in 5.26 or 5.27?
Comment 3 Nate Graham 2022-10-20 16:34:25 UTC 
Yeah, it would require more screen space, especially with 3x3 grids.

Until that happens, the request to make the shortcuts work as you expect within Overview seems reasonable to me. Since I hijacked your bug report to be about something else (sorry) could you file a new one for the original request? Thanks!
Comment 4 Niccolò Venerandi 2023-09-25 11:15:05 UTC 
Git commit 028dd552cfb9d826b40b9620d869c98d2aa3dca3 by Niccolò Venerandi.
Committed on 25/09/2023 at 13:14.
Pushed by niccolove into branch 'master'.

Merge desktop grid and overview together with a new three-state design

Merges the desktop grid and overview effects together in a new three-state one;
you can switch between them with a certain shortcut or gesture, and you can also
still access either the desktop grid or overview directly.

Default shortcuts are also updated to be Meta+G for Grid, Meta+W for Overview,
Meta+Tab to switch between the three states and Meta+Shift+Tab to cycle in the
opposite direction.
Related: bug 474044, bug 460774, bug 456572, bug 449601, bug 450262, bug 449801, bug 461510, bug 463886, bug 459754, bug 459749, bug 459748, bug 459467
FIXED-IN: 6.0

M  +2    -0    CMakeLists.txt
A  +7    -0    kconf_update/CMakeLists.txt
A  +20   -0    kconf_update/kwin-6.0-overview-activities-shortcuts.py
A  +11   -0    kconf_update/kwin.upd
M  +16   -3    src/libkwineffects/effecttogglablestate.cpp
M  +3    -1    src/libkwineffects/effecttogglablestate.h
M  +0    -1    src/plugins/CMakeLists.txt
D  +0    -49   src/plugins/desktopgrid/CMakeLists.txt
D  +0    -127  src/plugins/desktopgrid/desktopgrid_config.cpp
D  +0    -48   src/plugins/desktopgrid/desktopgrid_config.h
D  +0    -206  src/plugins/desktopgrid/desktopgrid_config.ui
D  +0    -32   src/plugins/desktopgrid/desktopgridconfig.kcfg
D  +0    -9    src/plugins/desktopgrid/desktopgridconfig.kcfgc
D  +0    -250  src/plugins/desktopgrid/desktopgrideffect.cpp
D  +0    -99   src/plugins/desktopgrid/desktopgrideffect.h
D  +0    -18   src/plugins/desktopgrid/main.cpp
D  +0    -92   src/plugins/desktopgrid/metadata.json
D  +0    -306  src/plugins/desktopgrid/qml/DesktopView.qml
D  +0    -328  src/plugins/desktopgrid/qml/main.qml
M  +27   -6    src/plugins/overview/kcm/overvieweffectkcm.cpp
M  +15   -1    src/plugins/overview/kcm/overvieweffectkcm.ui
M  +3    -0    src/plugins/overview/overviewconfig.kcfg
M  +229  -24   src/plugins/overview/overvieweffect.cpp
M  +37   -16   src/plugins/overview/overvieweffect.h
M  +44   -36   src/plugins/overview/qml/DesktopBar.qml
M  +541  -193  src/plugins/overview/qml/main.qml
M  +24   -18   src/plugins/private/qml/WindowHeapDelegate.qml
M  +1    -0    src/plugins/windowview/qml/main.qml
M  +0    -2    src/plugins/windowview/windowvieweffect.cpp

https://invent.kde.org/plasma/kwin/-/commit/028dd552cfb9d826b40b9620d869c98d2aa3dca3