Bug 454167 - Invert Selection in toolbar cannot be translated
Summary: Invert Selection in toolbar cannot be translated
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Translation (other bugs)
Version First Reported In: nightly build (please specify the git hash!)
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: Alvin Wong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-21 15:42 UTC by Tyson Tan
Modified: 2022-05-26 09:48 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/krita/commit/df2a62ba616be23e890bf300fbfe5580f3716d20
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2022-05-21 15:42:32 UTC 
The action "Invert Selection" in toolbar is untranslatable. It's always shown in English, regardless of the current locale.

For example, both Simplified Chinese and Traditional Chinese have been 100% translated, but "Invert Selection" still shows up as English in toolbar.
Comment 1 Bug Janitor Service 2022-05-23 15:23:42 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1457
Comment 2 Alvin Wong 2022-05-24 06:52:54 UTC 
Git commit df2a62ba616be23e890bf300fbfe5580f3716d20 by Alvin Wong.
Committed on 23/05/2022 at 15:05.
Pushed by rempt into branch 'master'.

Fix action_i18n.pl not extracting iconText

Also change it to not consider the `comment` attribute to be the context
string to match the expectation of `kis_action_registry.cpp`.

Also add the tag name to the i18n comment for clarity for translators.

M  +3    -8    action_i18n.pl

https://invent.kde.org/graphics/krita/commit/df2a62ba616be23e890bf300fbfe5580f3716d20
Comment 3 Tyson Tan 2022-05-24 07:00:07 UTC 
Thank you Alvin!
Comment 4 Alvin Wong 2022-05-26 09:48:35 UTC 
Git commit bb4c285dc396c89e0d640c01d1feb8badb412bbd by Alvin Wong.
Committed on 26/05/2022 at 09:48.
Pushed by alvinwong into branch 'master'.

Revert "Fix action text being untranslated in Configure Toolbar"

Now that iconText can be properly translated, we probably can revert to
it so that the text shown in the right-hand list actually matches that
when shown on the toolbar.

This text may revert to English until the translations have been
updated.

This reverts commit 713e98803eaec18a2292d99649c4ce1a72251860.
Related: bug 448027

M  +1    -1    libs/widgetutils/xmlgui/kedittoolbar.cpp

https://invent.kde.org/graphics/krita/commit/bb4c285dc396c89e0d640c01d1feb8badb412bbd