In main menu > Configure > Configure Toolbar The actions with an "&" in their names, like "F&ull Screen", "&Show Canvas Only" become untranslated when added from Available action list to Current action list. &Show Canvas Only #: krita/kritamenu.action:616 F&ull Screen Mode #: krita/kritamenu.action:628 My guess is that the "&" (&) is causing the issue, because every action in that file with an & seem to be broken in the same way. If that's the case, I recommend checking other .action files as well.
Git commit 713e98803eaec18a2292d99649c4ce1a72251860 by Alvin Wong. Committed on 06/01/2022 at 16:52. Pushed by alvinwong into branch 'master'. Fix action text being untranslated in Configure Toolbar In the "Current actions" list we should use QAction::text() like the "Available list", instead of QAction::iconText(), because the `iconText` defined in .action files are not being extracted for i18n and therefore can be untranslated when different from `text`. Maybe we should review how and where `iconText` is actually being used, and either remove it or make sure they are translated? M +1 -1 libs/widgetutils/xmlgui/kedittoolbar.cpp https://invent.kde.org/graphics/krita/commit/713e98803eaec18a2292d99649c4ce1a72251860
Git commit 6da0b2fe3ef13d8649e30ad70ece0b4a93cc44bf by Alvin Wong. Committed on 06/01/2022 at 16:54. Pushed by alvinwong into branch 'krita/5.0'. Fix action text being untranslated in Configure Toolbar In the "Current actions" list we should use QAction::text() like the "Available list", instead of QAction::iconText(), because the `iconText` defined in .action files are not being extracted for i18n and therefore can be untranslated when different from `text`. Maybe we should review how and where `iconText` is actually being used, and either remove it or make sure they are translated? (cherry picked from commit 713e98803eaec18a2292d99649c4ce1a72251860) M +1 -1 libs/widgetutils/xmlgui/kedittoolbar.cpp https://invent.kde.org/graphics/krita/commit/6da0b2fe3ef13d8649e30ad70ece0b4a93cc44bf
Thank you, Alvin! :D
Git commit bb4c285dc396c89e0d640c01d1feb8badb412bbd by Alvin Wong. Committed on 26/05/2022 at 09:48. Pushed by alvinwong into branch 'master'. Revert "Fix action text being untranslated in Configure Toolbar" Now that iconText can be properly translated, we probably can revert to it so that the text shown in the right-hand list actually matches that when shown on the toolbar. This text may revert to English until the translations have been updated. This reverts commit 713e98803eaec18a2292d99649c4ce1a72251860. Related: bug 454167 M +1 -1 libs/widgetutils/xmlgui/kedittoolbar.cpp https://invent.kde.org/graphics/krita/commit/bb4c285dc396c89e0d640c01d1feb8badb412bbd
Thank you Alvin, the strings in toolbar are now properly translated, we only need to rebuild the translation once. Our local community wanted me to tell you that they really appreciate your effort fixing all these translation related problems. BTW, I don't know if I should say it here, but Krita's HSV Adjustment filter has the Value/Lightness/Intensity/Luminosity strings untranslatable in 5.1 branch. It has been reported as https://bugs.kde.org/show_bug.cgi?id=454210 , but no one is looking into it. Can you help with that too? Thanks!