Bug 454001 - middle-clicking windows on the grid is broken
Summary: middle-clicking windows on the grid is broken
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-desktop-grid (show other bugs)
Version: 5.24.90
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: regression
: 454264 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-05-18 16:29 UTC by bastimeyer123
Modified: 2022-05-27 12:06 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.25
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description bastimeyer123 2022-05-18 16:29:35 UTC
Initial report: BUG 453943

SUMMARY
After the recent QML rewrite of the desktopgrid effect, middle clicking a window doesn't do anything anymore. Previously, a middle click was toggling the "show on all desktops" state of the clicked window.

This report could be interpreted as a duplicate of BUG 206501, which is an old feature request for being able to change the behavior to "close window", which makes much more sense IMO compared to showing on all desktops, especially when lots of desktops are set up. Middle clicking tabs in a web browser will close them, Plasma's task manager has an option for closing applications/groups via middle-click, and the desktop-grid should allow the user to do the same. This would be consistent and a better user experience.


STEPS TO REPRODUCE
1. set up a grid
2. open a window
3. open grid and middle click window


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.4


ADDITIONAL INFORMATION
- KWin built from 09ba8729fc12 (current master) using the modified PKGBUILD of the Arch repos
- kdecoration built from 4123ec8c1993 (current master) using the modified PKGBUILD of the Arch repos
- plasma-wayland-protocols built from 26fb07b9f8d3 (current master) using the modified PKGBUILD of the Arch repos
- the remaining dependencies were all from the official Arch repos
Comment 1 Bacteria 2022-05-24 06:28:19 UTC
*** Bug 454264 has been marked as a duplicate of this bug. ***
Comment 2 Bug Janitor Service 2022-05-26 12:44:12 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/2475
Comment 3 Vlad Zahorodnii 2022-05-27 08:59:06 UTC
Git commit f6db8b11780af697fedacd0a6f4eb499041c828a by Vlad Zahorodnii, on behalf of Marco Martin.
Committed on 27/05/2022 at 08:29.
Pushed by vladz into branch 'master'.

Toggle all desktop on middle click

restores the behavior of the old desktop grid which toggled on all desktops on middle click

M  +10   -0    src/effects/desktopgrid/qml/DesktopView.qml
M  +6    -0    src/effects/overview/qml/ScreenView.qml
M  +6    -3    src/effects/private/qml/WindowHeap.qml
M  +6    -0    src/effects/windowview/qml/main.qml

https://invent.kde.org/plasma/kwin/commit/f6db8b11780af697fedacd0a6f4eb499041c828a
Comment 4 Vlad Zahorodnii 2022-05-27 09:06:28 UTC
Git commit 6f3a72be907a2c4c42dc96483278a984b76fd616 by Vlad Zahorodnii, on behalf of Marco Martin.
Committed on 27/05/2022 at 09:06.
Pushed by vladz into branch 'Plasma/5.25'.

Toggle all desktop on middle click

restores the behavior of the old desktop grid which toggled on all desktops on middle click


(cherry picked from commit f6db8b11780af697fedacd0a6f4eb499041c828a)

M  +10   -0    src/effects/desktopgrid/qml/DesktopView.qml
M  +6    -0    src/effects/overview/qml/ScreenView.qml
M  +6    -3    src/effects/private/qml/WindowHeap.qml
M  +6    -0    src/effects/windowview/qml/main.qml

https://invent.kde.org/plasma/kwin/commit/6f3a72be907a2c4c42dc96483278a984b76fd616