Bug 453426 - New QML version of Present Windows can't (optionally) exclude minimized windows
Summary: New QML version of Present Windows can't (optionally) exclude minimized windows
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-present-windows (show other bugs)
Version: git master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: regression
Depends on:
Blocks: 329540
  Show dependency tree / graph
 
Reported: 2022-05-05 15:22 UTC by Nate Graham
Modified: 2022-05-06 15:48 UTC (History)
0 users

See Also:
Latest Commit: https://invent.kde.org/plasma/kwin/commit/eca9b5047ab4833cb33de81b1e75a128f5d758e1
Version Fixed In: 5.25
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2022-05-05 15:22:47 UTC 
This was a feature of the old one, and I used it and miss it.

I want it in the Overview effect too (see Bug 441627), so maybe the tech stack can implement it in a way that both get it?
Comment 1 Marco Martin 2022-05-06 11:37:50 UTC 
Git commit ae1937badc097a864ecfc62e79e7a3899c3be572 by Marco Martin.
Committed on 06/05/2022 at 11:37.
Pushed by mart into branch 'master'.

Remove completely present windows

since it has been replaced by windowview, and Desktop Grid
is ported as well, remove present windows which is effectively dead code
now
Related: bug 447001, bug 362844, bug 450487, bug 374481, bug 185381, bug 413342, bug 451150, bug 283333, bug 315314, bug 397500, bug 321236, bug 436572, bug 335782

M  +0    -1    src/effects/CMakeLists.txt
D  +0    -45   src/effects/presentwindows/CMakeLists.txt
D  +0    -17   src/effects/presentwindows/main.cpp
D  +0    -18   src/effects/presentwindows/main.qml
D  +0    -75   src/effects/presentwindows/metadata.json
D  +0    -2054 src/effects/presentwindows/presentwindows.cpp
D  +0    -343  src/effects/presentwindows/presentwindows.h
D  +0    -51   src/effects/presentwindows/presentwindows.kcfg
D  +0    -104  src/effects/presentwindows/presentwindows_config.cpp
D  +0    -46   src/effects/presentwindows/presentwindows_config.h
D  +0    -487  src/effects/presentwindows/presentwindows_config.ui
D  +0    -36   src/effects/presentwindows/presentwindows_proxy.cpp
D  +0    -35   src/effects/presentwindows/presentwindows_proxy.h
D  +0    -6    src/effects/presentwindows/presentwindowsconfig.kcfgc

https://invent.kde.org/plasma/kwin/commit/ae1937badc097a864ecfc62e79e7a3899c3be572
Comment 2 Nate Graham 2022-05-06 13:23:23 UTC 
Removing the old code doesn't make bugs affecting the new code go away; re-opening.
Comment 3 Nate Graham 2022-05-06 15:48:47 UTC 
Git commit eca9b5047ab4833cb33de81b1e75a128f5d758e1 by Nate Graham, on behalf of Marco Martin.
Committed on 06/05/2022 at 15:48.
Pushed by ngraham into branch 'master'.

effects/windowview+overview: get back option to hide minimized windows

Option to hide minimized windows as old present windows effect had.
Related: bug 441627
FIXED-IN: 5.25

M  +16   -5    src/effects/overview/kcm/overvieweffectkcm.ui
M  +3    -0    src/effects/overview/overviewconfig.kcfg
M  +5    -0    src/effects/overview/overvieweffect.cpp
M  +4    -0    src/effects/overview/overvieweffect.h
M  +1    -0    src/effects/overview/qml/ScreenView.qml
M  +5    -4    src/effects/windowview/kcm/windowvieweffectkcm.ui
M  +1    -0    src/effects/windowview/qml/main.qml
M  +3    -0    src/effects/windowview/windowviewconfig.kcfg
M  +5    -0    src/effects/windowview/windowvieweffect.cpp
M  +4    -0    src/effects/windowview/windowvieweffect.h
M  +20   -0    src/scripting/v3/clientmodel.cpp
M  +6    -0    src/scripting/v3/clientmodel.h

https://invent.kde.org/plasma/kwin/commit/eca9b5047ab4833cb33de81b1e75a128f5d758e1