Bug 451919 - "Default.utf-8" and "C" both claim to be the default value
Summary: "Default.utf-8" and "C" both claim to be the default value
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_formats (show other bugs)
Version: 5.24.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-26 08:44 UTC by David
Modified: 2022-07-02 09:31 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
format_warning (35.41 KB, image/png)
2022-03-26 08:44 UTC, David
Details
time_locale_defaults (138.30 KB, image/png)
2022-04-11 19:57 UTC, David
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David 2022-03-26 08:44:10 UTC
Created attachment 147736 [details]
format_warning

SUMMARY
If I change the time format in the system settings to something other than the default, and then change it back to the default, somehow it will not behave the same as an unchanged system default anymore, and some applications give me warnings about it (see screenshot).

STEPS TO REPRODUCE
1. Go to System Settings -> Regional Settings -> Formats -> Time, and select something other than the default.
2. Reboot the computer.
3. Repeat step 1, but this time selecting the default.
4. Reboot the computer.
5. Use random non-KDE applications and see what they have to say, such as sublime text.

OBSERVED RESULT
Some appications give warnings about the system formats being invalid.

EXPECTED RESULT
Everything should work the same as if the formats had never been changed.

SOFTWARE/OS VERSIONS
Operating System: Debian GNU/Linux
KDE Plasma Version: 5.24.3
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.2
Kernel Version: 5.16.0-5-amd64 (64-bit)
Graphics Platform: X11
Processors: 16 × AMD Ryzen 7 2700 Eight-Core Processor
Memory: 15.6 GiB of RAM
Graphics Processor: AMD VEGA10
Comment 1 Nate Graham 2022-03-26 16:19:38 UTC
Can you paste the output of `cat ~/.config/plasma-localerc`?
Comment 2 David 2022-03-26 19:55:33 UTC
(In reply to Nate Graham from comment #1)
> Can you paste the output of `cat ~/.config/plasma-localerc`?

Output is as follows:
[Formats]
LANG=en_US.UTF-8
LC_TIME=C
Comment 3 Bug Janitor Service 2022-04-10 04:34:59 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 David 2022-04-10 08:18:23 UTC
(In reply to Bug Janitor Service from comment #3)
> Dear Bug Submitter,
> 
> This bug has been in NEEDSINFO status with no change for at least
> 15 days. Please provide the requested information as soon as
> possible and set the bug status as REPORTED. Due to regular bug
> tracker maintenance, if the bug is still in NEEDSINFO status with
> no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
> due to lack of needed information.
> 
> For more information about our bug triaging procedures please read the
> wiki located here:
> https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging
> 
> If you have already provided the requested information, please
> mark the bug as REPORTED so that the KDE team knows that the bug is
> ready to be confirmed.
> 
> Thank you for helping us make KDE software even better for everyone!

All info is already provided.
Comment 5 Nate Graham 2022-04-11 16:58:51 UTC
Ok, so LC_TIME is being set to C. That's not supposed to be the default. When you say, "3. Repeat step 1, but this time selecting the default", did you click on C explicitly? Or something else? Can you `cat ~/.config/plasma-localerc` again after clicking the "Defaults" button at the bottom of the window?

Also after you provide the requested information, please set the status back to "REPORTED." Thanks!
Comment 6 David 2022-04-11 19:07:20 UTC
(In reply to Nate Graham from comment #5)
> Ok, so LC_TIME is being set to C. That's not supposed to be the default.
> When you say, "3. Repeat step 1, but this time selecting the default", did
> you click on C explicitly? Or something else? Can you `cat
> ~/.config/plasma-localerc` again after clicking the "Defaults" button at the
> bottom of the window?
> 
> Also after you provide the requested information, please set the status back
> to "REPORTED." Thanks!

That "C" is called "Default", the same as the "UTF-8", even though neither of those removes the lice from from `plasma-localerc`.
Comment 7 Nate Graham 2022-04-11 19:34:15 UTC
Can you `cat ~/.config/plasma-localerc` again after clicking the "Defaults" button at the bottom of the window?
Comment 8 David 2022-04-11 19:37:01 UTC
(In reply to Nate Graham from comment #7)
> Can you `cat ~/.config/plasma-localerc` again after clicking the "Defaults"
> button at the bottom of the window?

https://bugs.kde.org/show_bug.cgi?id=451944
Comment 9 Nate Graham 2022-04-11 19:43:37 UTC
You still didn't answer the question. :/

Are you trying to say that this is the same issue as Bug 451944?
Comment 10 David 2022-04-11 19:46:36 UTC
(In reply to Nate Graham from comment #9)
> You still didn't answer the question. :/
> 
> Are you trying to say that this is the same issue as Bug 451944?

No, clicking that "Defaults" button will reset it to whatever I had at the beginning of the session (doesn't remove the line unless the line would have been missing when I started the plasma session).
Comment 11 Nate Graham 2022-04-11 19:47:34 UTC
Then it seems like it's the same issue of what counts as "default" being incorrect.

*** This bug has been marked as a duplicate of bug 451944 ***
Comment 12 David 2022-04-11 19:48:37 UTC
(In reply to Nate Graham from comment #11)
> Then it seems like it's the same issue of what counts as "default" being
> incorrect.
> 
> *** This bug has been marked as a duplicate of bug 451944 ***

But it's not the same - the linked bug is about the button at the bottom, this one is about the options called "Default" which are at the top.
Comment 13 Nate Graham 2022-04-11 19:52:36 UTC
They both share the same data source, so fixing one bug automatically fixes the other one. Hence they share root causes, and are therefore duplicates. :)
Comment 14 David 2022-04-11 19:54:26 UTC
(In reply to Nate Graham from comment #13)
> They both share the same data source, so fixing one bug automatically fixes
> the other one. Hence they share root causes, and are therefore duplicates. :)

They aren't, since the ones at the top will change the localerc line to say "C" or "UTF-8", regardless of what was there at the beginning of the session.
Comment 15 David 2022-04-11 19:57:18 UTC
Created attachment 148109 [details]
time_locale_defaults

Perhaps a screenshot will clarify it.
Comment 16 Nate Graham 2022-04-12 16:03:13 UTC
So I guess an issue is that we have two things claiming to be the default item, which is logically impossible.

I can confirm that.
Comment 17 hanyoung 2022-07-02 09:31:47 UTC
Git commit 134e2d5c989c36ac0e985ee0ae382996c6b7b56e by Han Young.
Committed on 02/07/2022 at 09:29.
Pushed by hanyoung into branch 'master'.

merge Language and Formats
Related: bug 192019, bug 341235, bug 344588, bug 394477, bug 397974, bug 397975, bug 403580, bug 417564, bug 420268, bug 429474, bug 431292, bug 444772, bug 446785, bug 447787, bug 448324, bug 448355, bug 451944, bug 454991

closes https://invent.kde.org/plasma/plasma-workspace/-/issues/23

M  +1    -0    .kde-ci.yml
M  +52   -8    CMakeLists.txt
M  +2    -1    config-workspace.h.cmake
D  +0    -2    doc/kcontrol/formats/CMakeLists.txt
D  +0    -63   doc/kcontrol/formats/index.docbook
R  +1    -1    doc/kcontrol/region_language/CMakeLists.txt [from: doc/kcontrol/translations/CMakeLists.txt - 063% similarity]
R  +-    --    doc/kcontrol/region_language/go-top.png [from: doc/kcontrol/translations/go-top.png - 100% similarity]
R  +36   -23   doc/kcontrol/region_language/index.docbook [from: doc/kcontrol/translations/index.docbook - 050% similarity]
A  +-    --    doc/kcontrol/region_language/list-remove.png
D  +-    --    doc/kcontrol/translations/list-remove.png
M  +1    -2    kcms/CMakeLists.txt
D  +0    -30   kcms/formats/CMakeLists.txt
D  +0    -5    kcms/formats/Messages.sh
D  +0    -61   kcms/formats/formatssettings.kcfg
D  +0    -80   kcms/formats/kcmformats.cpp
D  +0    -34   kcms/formats/kcmformats.h
D  +0    -183  kcms/formats/localelistmodel.cpp
D  +0    -140  kcms/formats/optionsmodel.cpp
D  +0    -126  kcms/formats/package/contents/ui/main.qml
A  +75   -0    kcms/region_language/CMakeLists.txt
A  +8    -0    kcms/region_language/Messages.sh
R  +2    -27   kcms/region_language/exampleutility.cpp [from: kcms/formats/exampleutility.cpp - 052% similarity]
A  +22   -0    kcms/region_language/exampleutility.h     [License: GPL(v2.0+)]
A  +82   -0    kcms/region_language/kcm_regionandlang.desktop [TRAILING SPACE] ** [TRAILING SPACE] **
R  +4    -4    kcms/region_language/kcm_regionandlang.json [from: kcms/formats/kcm_formats.json - 098% similarity]
A  +250  -0    kcms/region_language/kcmregionandlang.cpp     [License: GPL(v2.0+)]
A  +58   -0    kcms/region_language/kcmregionandlang.h     [License: GPL(v2.0+)]
A  +372  -0    kcms/region_language/languagelistmodel.cpp     [License: GPL(v2.0+)]
A  +100  -0    kcms/region_language/languagelistmodel.h     [License: GPL(v2.0+)]
A  +30   -0    kcms/region_language/localegenerator.cpp     [License: LGPL(v2.0+)]
A  +17   -0    kcms/region_language/localegenerator.h     [License: LGPL(v2.0+)]
A  +19   -0    kcms/region_language/localegeneratorbase.cpp     [License: GPL(v2.0+)]
A  +23   -0    kcms/region_language/localegeneratorbase.h     [License: GPL(v2.0+)]
A  +32   -0    kcms/region_language/localegeneratorglibc.cpp     [License: GPL(v2.0+)]
A  +24   -0    kcms/region_language/localegeneratorglibc.h     [License: GPL(v2.0+)]
A  +101  -0    kcms/region_language/localegeneratorubuntu.cpp     [License: GPL(v2.0+)]
A  +27   -0    kcms/region_language/localegeneratorubuntu.h     [License: GPL(v2.0+)]
A  +36   -0    kcms/region_language/localegenhelper/CMakeLists.txt
A  +187  -0    kcms/region_language/localegenhelper/localegenhelper.cpp     [License: GPL(v2.0+)]
A  +46   -0    kcms/region_language/localegenhelper/localegenhelper.h     [License: GPL(v2.0+)]
A  +20   -0    kcms/region_language/localegenhelper/org.kde.localegenhelper.conf
A  +21   -0    kcms/region_language/localegenhelper/org.kde.localegenhelper.policy
A  +8    -0    kcms/region_language/localegenhelper/org.kde.localegenhelper.service.in
A  +158  -0    kcms/region_language/localelistmodel.cpp     [License: GPL (v2+)]
R  +22   -22   kcms/region_language/localelistmodel.h [from: kcms/formats/localelistmodel.h - 060% similarity]
A  +197  -0    kcms/region_language/optionsmodel.cpp     [License: GPL(v2.0+)]
R  +21   -11   kcms/region_language/optionsmodel.h [from: kcms/formats/optionsmodel.h - 054% similarity]
A  +204  -0    kcms/region_language/package/contents/ui/AdvancedLanguageSelectPage.qml     [License: LGPL(v3.0+)]
A  +238  -0    kcms/region_language/package/contents/ui/main.qml     [License: LGPL(v3.0+)]
A  +64   -0    kcms/region_language/regionandlangsettings.cpp     [License: GPL(v2.0+)]
A  +21   -0    kcms/region_language/regionandlangsettings.h     [License: GPL(v2.0+)]
A  +37   -0    kcms/region_language/regionandlangsettingsbase.kcfg
R  +2    -2    kcms/region_language/regionandlangsettingsbase.kcfgc [from: kcms/formats/formatssettings.kcfgc - 055% similarity]
A  +17   -0    kcms/region_language/settingtype.h     [License: GPL(v2.0+)]
D  +0    -49   kcms/translations/CMakeLists.txt
D  +0    -2    kcms/translations/Messages.sh
D  +0    -191  kcms/translations/language.cpp
D  +0    -32   kcms/translations/language.h
D  +0    -312  kcms/translations/package/contents/ui/main.qml
D  +0    -86   kcms/translations/translations.cpp
D  +0    -53   kcms/translations/translations.h
D  +0    -193  kcms/translations/translationsmodel.cpp
D  +0    -72   kcms/translations/translationsmodel.h
D  +0    -27   kcms/translations/translationssettings.cpp
D  +0    -24   kcms/translations/translationssettings.h
D  +0    -28   kcms/translations/translationssettingsbase.kcfg
D  +0    -6    kcms/translations/translationssettingsbase.kcfgc

The files marked with ** at the end have a problem. Either the file contains a trailing space or the file contains a call to potentially dangerous code. Please read: https://community.kde.org/Sysadmin/CommitHooks#Email_notifications for further information. Please either fix the trailing space or review the dangerous code.


https://invent.kde.org/plasma/plasma-workspace/commit/134e2d5c989c36ac0e985ee0ae382996c6b7b56e