Bug 449272 - Use in-page style for GHNS dialogs, rather than separate windows
Summary: Use in-page style for GHNS dialogs, rather than separate windows
Status: REPORTED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-27 23:10 UTC by Photon
Modified: 2022-01-31 10:25 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Photon 2022-01-27 23:10:10 UTC
This would make the design more consistent with modal dialogs of Kirigami stuff, such as the one used to change SDDM background, for example. It would also fix https://bugs.kde.org/show_bug.cgi?id=437653, maybe?
Comment 1 Nate Graham 2022-01-27 23:38:53 UTC
These dialogs you're thinking of are implemented using Kirigami.OverlaySheet, which isn't designed for a UI as large as this. In fact, these dialogs use Kirigami.OverlaySheets inside themselves!

The only UI change we could consider here is going in the opposite direction and make the dialogs into pages, so that they seem integrated into the main window itself. System Monitor already does that, and we could conceivably do the same thing for the GHNS dialogs in QtQuick KCMs.

I wouldn't be against it.

However we couldn't use this style everywhere; for example it wouldn't for the dialog that you can access from the Widget Explorer.
Comment 2 Photon 2022-01-28 18:20:20 UTC
> The only UI change we could consider here is going in the opposite direction and make the dialogs into pages, so that they seem integrated into the main window itself. 

It's a great solution.
Comment 3 Photon 2022-01-30 22:43:07 UTC
This would also fix that issue where the search box is hidden in a ellipsis menu.
Comment 4 Dan Leinir Turthra Jensen 2022-01-31 10:25:48 UTC
Just to weigh in on my own here, this is actually the intention for the medium/long term - basically, when i originally built all this, both the KNSQuick Button and Dialog controls were always intended effectively as porting aides, since that method of interaction (as this report also suggests) basically just doesn't fit into what our UI is evolving into. So, from my point of view: Yes please, definitely do that :) (as Nate says, of course, this wouldn't work everywhere, but in the places where it /would/ work, definitely what we want to try to go for)