Bug 437653 - KNewStuff dialogs have no close button in the titlebar
Summary: KNewStuff dialogs have no close button in the titlebar
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.88.0
Platform: Other Linux
: VHI normal
Target Milestone: ---
Assignee: Alexander Lohnau
URL:
Keywords: regression
: 437686 440576 445985 446788 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-05-25 10:53 UTC by Alexander Lohnau
Modified: 2023-09-20 20:28 UTC (History)
11 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/knewstuff/commit/ea19fa6e824650f3257e8047d6f90e01899b2e03
Version Fixed In: 5.93

Attachments
xprop output (1.59 KB, text/plain)
2021-06-07 08:18 UTC, Alexander Lohnau 		Details
GammaRay (454.09 KB, video/mp4)
2021-12-20 01:31 UTC, Nagy Tibor 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Lohnau 2021-05-25 10:53:07 UTC 
SUMMARY


STEPS TO REPRODUCE
1. Run `knewstuff-dialog icons.knsrc`

OBSERVED RESULT
The window has no close button. When right clicking on the window in the task manager the close entry is disabled.

EXPECTED RESULT
The window should have a close button.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Alexander Lohnau 2021-05-26 04:51:48 UTC 
*** Bug 437686 has been marked as a duplicate of this bug. ***
Comment 2 Nate Graham 2021-05-26 21:39:37 UTC 
Dan, can you look into this? It only seems to affect GHNS dialogs.
Comment 3 Vlad Zahorodnii 2021-06-07 08:15:34 UTC 
Can you please post the xprop output for GHNS? If motif hints don't permit close action, it's a client bug.
Comment 4 Alexander Lohnau 2021-06-07 08:18:17 UTC 
Created attachment 139066 [details]
xprop output
Comment 5 Nate Graham 2021-08-04 18:06:50 UTC 
*** Bug 440576 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2021-08-04 18:07:37 UTC 
> _MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x3, 0x1e, 0x6e, 0x0, 0x0
Does this mean anything to you, Vlad? :)
Comment 7 Nate Graham 2021-11-24 18:14:59 UTC 
*** Bug 445985 has been marked as a duplicate of this bug. ***
Comment 8 Nate Graham 2021-12-14 17:49:31 UTC 
*** Bug 446788 has been marked as a duplicate of this bug. ***
Comment 9 Nate Graham 2021-12-17 19:18:41 UTC 
*** Bug 447114 has been marked as a duplicate of this bug. ***
Comment 10 Bill Coady 2021-12-17 19:57:57 UTC 
I am not entirely sure this is the same bug as I reported.  On my system there IS a close button, it just not function as expected.  A single click does nothing and a double click acts as a minimize/maximize button.

But the close button IS there.
Comment 11 Nate Graham 2021-12-20 00:17:06 UTC 
Seems like this is an X11-specific problem; the button appears for me on Wayland, but not on X11.
Comment 12 Nagy Tibor 2021-12-20 01:31:39 UTC 
Created attachment 144693 [details]
GammaRay

GammaRay says that window's flags is missing WindowCloseButtonHint.
Comment 13 Photon 2022-01-27 23:13:47 UTC 
What if KNewStuff dialogs were transformed into modal dialogs such as the one used to change SDDM background, for example? https://bugs.kde.org/show_bug.cgi?id=449272
Comment 14 Bug Janitor Service 2022-01-28 06:13:28 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/211
Comment 15 Alexander Lohnau 2022-01-28 11:45:50 UTC 
Git commit 5d00aefc464bfedd5df00225c21e13063edcf17c by Alexander Lohnau.
Committed on 28/01/2022 at 06:07.
Pushed by alex into branch 'Plasma/5.24'.

Fix compilation on Plasma/5.24 branch

M  +1    -0    faces/CMakeLists.txt

https://invent.kde.org/plasma/libksysguard/commit/5d00aefc464bfedd5df00225c21e13063edcf17c
Comment 16 Bug Janitor Service 2022-03-07 20:14:19 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/171
Comment 17 Nate Graham 2022-03-08 15:03:58 UTC 
Git commit ea19fa6e824650f3257e8047d6f90e01899b2e03 by Nate Graham, on behalf of Alexander Lohnau.
Committed on 08/03/2022 at 15:03.
Pushed by ngraham into branch 'master'.

Fix close button for NewStuff.Dialog not existing on X11

We need this to be a proper window in order for it to have window
decorations like the close button.
FIXED-IN: 5.93

M  +10   -5    src/qtquick/qml/Dialog.qml

https://invent.kde.org/frameworks/knewstuff/commit/ea19fa6e824650f3257e8047d6f90e01899b2e03
Comment 18 Nate Graham 2023-09-20 20:28:50 UTC 
Looks like the fix for this issue was a workaround for Bug 464193 that only worked for this window. Bug 464193 tracks the root cause.