Bug 449069 - Icons on desktop sorted by name and aligned to right side are sorted from right to left
Summary: Icons on desktop sorted by name and aligned to right side are sorted from rig...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: 6.1.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-24 11:25 UTC by Patrick Silva
Modified: 2024-11-06 16:30 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.3.0
Sentry Crash Report:


Attachments
bug - icons are sorted from right to left (824.86 KB, image/png)
2022-01-24 11:25 UTC, Patrick Silva
Details
expected - icons are sorted from left to right (824.21 KB, image/png)
2022-01-24 11:26 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2022-01-24 11:25:52 UTC
Created attachment 145850 [details]
bug - icons are sorted from right to left

STEPS TO REPRODUCE
1. add several icons to desktop
2. right-click on desktop, choose 'Configure desktop and wallpapers...', click on 'Icons' in the left side
3. arrange icons in columns, align icons to right, sort icons by name, check 'Folders first'
4. click on 'OK' button

OBSERVED RESULT
icons on desktop are sorted from right to left. Compare the attached screenshots please.

EXPECTED RESULT
iocns on desktop should be sorted from left to right

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.24.80
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.3
Graphics Platform: Wayland
Comment 1 Patrick Silva 2022-01-24 11:26:36 UTC
Created attachment 145851 [details]
expected - icons are sorted from left to right
Comment 2 Patrick Silva 2022-01-24 11:31:31 UTC
The same happens if the icons on desktop are arranged in rows.
Comment 3 Nate Graham 2022-01-24 22:25:38 UTC
Can confirm.
Comment 4 TraceyC 2024-08-01 00:43:47 UTC
This seems related to general mishandling of icons on the desktop ex: https://bugs.kde.org/show_bug.cgi?id=468546
Comment 5 Akseli Lahtinen 2024-11-06 16:30:49 UTC
Git commit cc44615b34dacc2a4acfdc82de885c943318a7f6 by Akseli Lahtinen.
Committed on 06/11/2024 at 16:30.
Pushed by akselmo into branch 'master'.

Refactor icon positioner saving and loading

The icon positioner saving and loading is handled by QML, which makes it a bit difficult
to work with the logic in positioner CPP files.

This change does the following:
- Explicitly save only on user interactions
- Moved the save and load of config to positioner.cpp
  - Easier debugging of the saving and loading functions
  - Still uses the JSON style of save/loading like the old one
    - Technically should be compatible with the old config, which was also JSON.
- Makes positionerApplet accessible from FolderView qml
- Various checks for checking if screen is enabled or not to avoid doing unnecessary work when screen is off
- A lot of fixes to avoid any racing conditions
- Removed any timers
- Added various unit tests

Alternative to https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2603
Related: bug 482875, bug 494874, bug 472137, bug 433867, bug 494412, bug 468619, bug 495047, bug 453314
FIXED-IN: 6.3.0

M  +1    -1    containments/desktop/package/contents/ui/FolderView.qml
M  +1    -48   containments/desktop/package/contents/ui/FolderViewLayer.qml
M  +165  -26   containments/desktop/plugins/folder/autotests/positionertest.cpp
M  +18   -3    containments/desktop/plugins/folder/autotests/positionertest.h
M  +23   -7    containments/desktop/plugins/folder/foldermodel.cpp
M  +5    -0    containments/desktop/plugins/folder/foldermodel.h
M  +176  -60   containments/desktop/plugins/folder/positioner.cpp
M  +37   -8    containments/desktop/plugins/folder/positioner.h

https://invent.kde.org/plasma/plasma-desktop/-/commit/cc44615b34dacc2a4acfdc82de885c943318a7f6