Bug 448649 - Saving a clipboard edit after clearing the history doesn't make a new entry
Summary: Saving a clipboard edit after clearing the history doesn't make a new entry
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Clipboard widget & pop-up (show other bugs)
Version: 5.23.90
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
: 451362 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-01-17 12:02 UTC by Gabriel
Modified: 2022-12-09 15:08 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27
Sentry Crash Report:


Attachments
Video of the issue (67.73 KB, video/mp4)
2022-01-17 12:02 UTC, Gabriel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel 2022-01-17 12:02:09 UTC
Created attachment 145579 [details]
Video of the issue

SUMMARY
When in edit mode on an entry in the clipboard, it is still possible to clear the clipboard history. Doing so makes whatever edit you've done disappear, even after you've clicked save. When the edit mode was a separate window, saving would generate a new entry with the text instead.

STEPS TO REPRODUCE
1. Copy some text to the clipboard
2. Click edit
3. Clear history
4. Save

OBSERVED RESULT
The saved text is gone with the rest of the clipboard contents

EXPECTED RESULT
The clipboard contains the last saved entry

SOFTWARE
OS: KDE neon Testing Edition
KDE Plasma Version: 5.23.90
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.3

ADDITIONAL INFORMATION
The previous behavior was that saving would add back the edited text to the clipboard, but it's not obvious if that is the right way to solve this. Maybe it shouldn't be possible to clear history while editing, or clearing should kick you out of the editing mode instead.
Comment 1 Nate Graham 2022-01-21 00:30:41 UTC
Maybe we should disable the "clear all" button while editing an entry?
Comment 2 Bug Janitor Service 2022-01-21 01:23:05 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1388
Comment 3 Nate Graham 2022-03-23 14:43:53 UTC
*** Bug 451362 has been marked as a duplicate of this bug. ***
Comment 4 Bharadwaj Raju 2022-12-09 03:55:12 UTC
Git commit d8a82878c247dc33d09cec01d09652948a789d61 by Bharadwaj Raju.
Committed on 09/12/2022 at 03:55.
Pushed by bharadwaj-raju into branch 'master'.

applets/clipboard: Hide clear button when editing

M  +3    -0    applets/clipboard/contents/ui/EditPage.qml
M  +2    -1    applets/clipboard/contents/ui/clipboard.qml

https://invent.kde.org/plasma/plasma-workspace/commit/d8a82878c247dc33d09cec01d09652948a789d61