Bug 443626 - GTK toolbar buttons have outline
Summary: GTK toolbar buttons have outline
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: 5.23.0
Platform: openSUSE Linux
: VHI normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords: regression
: 444050 445678 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-10-12 07:54 UTC by Fabian Vogt
Modified: 2021-11-18 16:49 UTC (History)
7 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/breeze-gtk/commit/6834ee83d09b7c56fbe3d137b660db25484573f3
Version Fixed In: 5.23.4
Sentry Crash Report:

Attachments
Eclipse IDE with borders around toolbar icons after upgrading breeze-gtk-theme to 5.23 (14.17 KB, image/png)
2021-10-15 18:25 UTC, Efe Ciftci 		Details
breeze-gtk-5.23.0-fix-toolbar-buttons-style.patch (1.15 KB, patch)
2021-11-18 11:10 UTC, Yaroslav Sidlovsky 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Vogt 2021-10-12 07:54:48 UTC 
GTK toolbar buttons like in Inkscape have an outline like standalone push buttons now, which looks weird.

This wasn't the case with 5.22.90, so this is most likely caused by 3b2ce1abd2f45cf844c43cac6e7009a59bff0dd9 ("gtk3, gtk4: update button style")

Found by openQA: https://openqa.opensuse.org/tests/1963509#step/inkscape/19
Comment 1 Nate Graham 2021-10-12 13:14:21 UTC 
Can reproduce. gtk-widget-factory is okay and so is gedit, so this may end up being an app bug that we triggered with that change. Still, we should investigate and fix if possible.
Comment 2 Efe Ciftci 2021-10-15 18:25:09 UTC 
Created attachment 142481 [details]
Eclipse IDE with borders around toolbar icons after upgrading breeze-gtk-theme to 5.23

I can confirm Eclipse IDE (2021-09) is affected as well.
Comment 3 S. Christian Collins 2021-10-18 14:20:51 UTC 
Synaptic Package Manager is also affected.
Comment 4 Nate Graham 2021-10-20 13:49:56 UTC 
*** Bug 444050 has been marked as a duplicate of this bug. ***
Comment 5 Yaroslav Sidlovsky 2021-11-18 10:15:18 UTC 
*** Bug 445678 has been marked as a duplicate of this bug. ***
Comment 6 Yaroslav Sidlovsky 2021-11-18 10:20:57 UTC 
Same bug spotted in "Virt manager" and "FileZilla" (see duplicate: https://bugs.kde.org/show_bug.cgi?id=445678).
Comment 7 Unknown 2021-11-18 11:04:54 UTC 
OBSERVED RESULT
FileZilla: https://i.imgur.com/xuOHOxn.png
Virt Manager: https://i.imgur.com/kFIVRd5.png

EXPECTED RESULT
How they should like:
FileZilla: https://i.imgur.com/I9qSiY1.png
Virt Manager: https://i.imgur.com/LSDrhYq.png
Comment 8 Yaroslav Sidlovsky 2021-11-18 11:10:26 UTC 
Created attachment 143688 [details]
breeze-gtk-5.23.0-fix-toolbar-buttons-style.patch
Comment 9 Bug Janitor Service 2021-11-18 11:25:21 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/31
Comment 10 Yaroslav Sidlovsky 2021-11-18 16:47:27 UTC 
Git commit 23ba2a8dc728cd7105e5994ed1d4dc143f7d69a1 by Yaroslav Sidlovsky.
Committed on 18/11/2021 at 11:21.
Pushed by ngraham into branch 'master'.

Fixed toolbar buttons style, removing unneeded outline

M  +5    -0    src/gtk3/widgets/_button.scss

https://invent.kde.org/plasma/breeze-gtk/commit/23ba2a8dc728cd7105e5994ed1d4dc143f7d69a1
Comment 11 Nate Graham 2021-11-18 16:48:34 UTC 
Git commit 6834ee83d09b7c56fbe3d137b660db25484573f3 by Nate Graham, on behalf of Yaroslav Sidlovsky.
Committed on 18/11/2021 at 16:48.
Pushed by ngraham into branch 'Plasma/5.23'.

Fixed toolbar buttons style, removing unneeded outline


(cherry picked from commit 23ba2a8dc728cd7105e5994ed1d4dc143f7d69a1)

M  +5    -0    src/gtk3/widgets/_button.scss

https://invent.kde.org/plasma/breeze-gtk/commit/6834ee83d09b7c56fbe3d137b660db25484573f3
Comment 12 Nate Graham 2021-11-18 16:49:12 UTC 
Sorry for how long that took, everyone!