Bug 442937 - The "Do you really want to cancel?" dialog is shown even when nothing have been changed in the event/tasks editor
Summary: The "Do you really want to cancel?" dialog is shown even when nothing have be...
Status: REPORTED
Alias: None
Product: korganizer
Classification: Applications
Component: incidence editors (show other bugs)
Version: 5.18.1
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-25 10:20 UTC by Alexandre Bonneau
Modified: 2021-10-05 18:58 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
The annoying dialog (14.71 KB, image/png)
2021-09-25 10:20 UTC, Alexandre Bonneau
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Bonneau 2021-09-25 10:20:26 UTC
Created attachment 141901 [details]
The annoying dialog

SUMMARY
A few versions back, Korganizer introduced the "Do you really want to cancel?" dialog.
This dialog is supposed to be shown ONLY when you had unsaved/unapplied modification to the opened event or task, however it's ALWAYS displayed even when you just opened a task/event to take a quick look at it, without changing anything.
This is _really_ annoying.


STEPS TO REPRODUCE
1. In the agenda view, double click on any existing event or tasks
2. The event or task window is shown
3. Do not change anything, then click cancel or hit 'Escape'

OBSERVED RESULT
A modal dialog showing the string "Do you really want to cancel?" is shown.

EXPECTED RESULT
No dialog should be shown, and the event/task window should be closed immediately.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian Bullseye / Kernel 5.10.0-8-amd64 / 4:5.20.5-6
(available in About System)
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 5.78.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Korganizer version : 4:20.08.3-1

Do note that this is the same bug as in 2009 which has been resolved as fixed : https://bugs.kde.org/show_bug.cgi?id=195734
https://bugs.kde.org/show_bug.cgi?id=181981
https://bugs.kde.org/show_bug.cgi?id=184570
Comment 1 gjditchfield 2021-09-25 15:39:58 UTC
I can't reproduce this with 5.18.1.

This was fixed (I hope) in version 5.18.0 (21.08.0) by https://invent.kde.org/pim/incidenceeditor/-/merge_requests/18 -- items were always treated as having unsaved changes if they had tags.

For a quick test, create a new event and don't set any field except for the summary.  Close it, reopen it, and see if you get the annoying dialog.
Comment 2 Alexandre Bonneau 2021-09-26 02:43:12 UTC
I upgraded from Debian Bullseye to Bookworm (the current testing), and with Korganizer Version 5.18.1 (21.08.1), I unfortunately still see that behavior.

(Also, upgrading to 5.18.1 made it forgot the category colors when I double click on an event, then hit Esc, and click "Yes I want to cancel")
Comment 3 Alexandre Bonneau 2021-09-26 03:05:33 UTC
Ok so I tried a few things:
- create a new event with no tags ; opening that event and cancelling work as expected and does not show a warning. I then added a tag to that event, saved it. Then opened it again and hit Esc ; no modial dialog
- I created a new event with a tag; opening that event and cancelling work as expected and does not show a warning

- However when I open my existing events, the dialog is shown
(then the category color is removed (while the tag still exist (and is even in double/triple in the tag list now. Well, I removed the duplicated tags, and their color disappeared from the agenda view (while still being shown in the tag color configuration window. I had to restart Korganizer for that color to be shown again)
Comment 4 Alexandre Bonneau 2021-09-26 03:18:23 UTC
Ok this is not the relevant issue for this ticket, but the Tags management is a huge mess.
I thought I was, one by one, defining the lost colors everytime I opened the incidence editor of a previous element, but in fact Korganizer/akonadi was creating new tags with the exact same name.
So when I open another old event with the same tag, it removes the color...then I go change the color in the settings...then the tag is duplicated again :|

1. Duplicated names shouldn't be allowed for tags
2. When finding an ical CATEGORY, Korganizer/Akonadi should search if a color has been set and use that, instead of not finding the already configured tag/color, and forcing the user to create a duplicate.
Comment 5 gjditchfield 2021-09-26 15:15:06 UTC
(In reply to Alexandre Bonneau from comment #4)
> ... but in fact Korganizer/akonadi was
> creating new tags with the exact same name.

Yeah.  I think this is related to bug 441846, where cut&paste also duplicates tags.