Bug 195734 - "do you really want to cancel" alert appears, even when no changes.
Summary: "do you really want to cancel" alert appears, even when no changes.
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: 4.2.2
Platform: Ubuntu Unspecified
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-09 03:25 UTC by Ian Turner
Modified: 2009-06-17 12:18 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Turner 2009-06-09 03:25:02 UTC
Version:            (using KDE 4.2.2)
Installed from:    Ubuntu Packages

STEPS TO REPRODUCE:

1. Open an event's edit dialog.
2. Do not make any changes.
3. Click "Cancel".

EXPECTED BEHAVIOR:

The dialog box closes and no alert is displayed.

ACTUAL BEHAVIOR:

An alert box appears asking "Do you really want to cancel?"

ADDITIONAL COMMENTARY:

Personally I'm not convinced we should ever display this alert, even if there are changes; the consequences of accidentally clicking cancel in this context are almost always trivial. But if we are going to retain the dialog, we should at a minimum only use it when there were actual changes made.
Comment 1 Sergio Martins 2009-06-09 13:55:15 UTC
Does that happen when adding a new event or editing an old one?

I reproduced one scenario where that happens, i'll try to fix it when i have time.
Comment 2 Allen Winter 2009-06-09 15:03:15 UTC
We will keep the alert.  But we are developing smarter code to determine when the incidence has been modified so the dialog will only be shown as needed.

version  4.2.4 is much smarter than 4.2.2 in this regard.

we expect to make the modification detection better in the 4.3 series.
Comment 3 Ian Turner 2009-06-09 18:28:07 UTC
Sergio, in 4.2.2 you don't see the alert when cancelling a new to-do, only when cancelling the edit of an existing one.

Allen, is there a bug tracking this work? Perhaps this should be marked as a duplicate of that bug.
Comment 4 Sergio Martins 2009-06-13 22:42:11 UTC
SVN commit 981638 by smartins:

Fix the "Do you really want to cancel message" when closing the incidence editor.

CCBUG: 195734
MERGE: e4



 M  +1 -1      koeventeditor.cpp  
 M  +1 -1      kojournaleditor.cpp  
 M  +1 -1      kotodoeditor.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=981638
Comment 5 Sergio Martins 2009-06-13 23:03:56 UTC
SVN commit 981640 by smartins:


Incidence::operator== didn't worlk properly when there were attachments involved.

Fixed by implementing ListBase::operator== and Attachment::operator==.

Review: http://reviewboard.kde.org/r/821/

This was also one of the causes of bug 195734.

BUG: 195734
MERGE: e4



 M  +16 -0     attachment.cpp  
 M  +12 -0     attachment.h  
 M  +16 -0     listbase.h  
 M  +11 -0     tests/testattachment.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=981640
Comment 6 Thomas McGuire 2009-06-17 12:18:31 UTC
SVN commit 982948 by tmcguire:

Crossport r981640 by smartins from trunk to the enterprise4 branch:


Incidence::operator== didn't worlk properly when there were attachments involved.

Fixed by implementing ListBase::operator== and Attachment::operator==.

Review: http://reviewboard.kde.org/r/821/

This was also one of the causes of bug 195734.

CCBUG: 195734
MERGE: e4




 M  +16 -0     attachment.cpp  
 M  +12 -0     attachment.h  
 M  +16 -0     listbase.h  
 M  +11 -0     tests/testattachment.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=982948