Bug 442102 - Feature Request: Freeze the assistant guidelines in place while the pen is down
Summary: Feature Request: Freeze the assistant guidelines in place while the pen is down
Status: RESOLVED WORKSFORME
Alias: None
Product: krita
Classification: Applications
Component: Tool/Assistants (other bugs)
Version First Reported In: 5.0.0-beta1
Platform: Microsoft Windows Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-07 00:55 UTC by John Kirk
Modified: 2021-10-24 04:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Kirk 2021-09-07 00:55:02 UTC
When you use the 2-point perspective assistant, there are two guidelines that follow the cursor from each vanish point. It'd be useful if you could tick a box so they won't follow the cursor while drawing a line, instead fixing in place until the pen is lifted. The way it works right, with the guidelines always following the cursor, it really psyches you out when trying to use it with the "snap to assistants" turned off.
Comment 1 Tiar 2021-09-07 15:55:33 UTC
Maybe it would be better to just have a checkbox to disable the dynamic preview (the one following the cursor)? I think it would make more sense. In View -> there are already two checkboxes but frankly, I'm not sure which one should do what. Maybe it would be good to rethink that and make it consistent and useful.
Comment 2 Tiar 2021-09-22 12:08:28 UTC
Git commit a2e402e02ce5cad685d4bf3fc6a3f55c27c34ff4 by Agata Cacko.
Committed on 22/09/2021 at 11:57.
Pushed by tymond into branch 'master'.

Fix assistants preview vs drawn assistant

Before this commit, some (especially new) assistants were confused
what is the preview (which can be disabled with View -> Show
Assistants Preview) and what is the assistant itself
(which can be disabled with View -> Show Painting Assistants).
This commit fixes it for three assistants:
- Parallel Ruler
- Vanishing Point
- Two Point Assistant

Previews: all moving parts (dependant on the mouse position)
Assistants: all static parts (independant on the mouse position)

Note that Two Point and Vanishing Point assistants don't use
much of drawCache and most of the assistant is drawn in the
drawAssistant() function. This most probably means lower
performance and it should probably be fixed by moving
drawing the static parts of the assistants into the drawCache()
function.
Related: bug 433097

M  +2    -2    plugins/assistants/Assistants/ParallelRulerAssistant.cc
M  +9    -7    plugins/assistants/Assistants/TwoPointAssistant.cc
M  +20   -17   plugins/assistants/Assistants/VanishingPointAssistant.cc

https://invent.kde.org/graphics/krita/commit/a2e402e02ce5cad685d4bf3fc6a3f55c27c34ff4
Comment 3 Tiar 2021-09-22 12:49:36 UTC
@John Kirk the commit I added makes it more reliable when users disable or enable Show Painting Assistant and Show Assistant Preview in the View menu. If you disable Show Assistant Preview, it should disappear the dynamic lines that you dislike when you're not snapping to the assistant. Does it solve your issue?
Comment 4 Tiar 2021-09-24 13:49:01 UTC
Git commit 3f9634d312c8ec8c855e3a601b3b0517de618396 by Agata Cacko.
Committed on 24/09/2021 at 13:45.
Pushed by tymond into branch 'krita/5.0'.

Fix assistants preview vs drawn assistant

Before this commit, some (especially new) assistants were confused
what is the preview (which can be disabled with View -> Show
Assistants Preview) and what is the assistant itself
(which can be disabled with View -> Show Painting Assistants).
This commit fixes it for three assistants:
- Parallel Ruler
- Vanishing Point
- Two Point Assistant

Previews: all moving parts (dependant on the mouse position)
Assistants: all static parts (independant on the mouse position)

Note that Two Point and Vanishing Point assistants don't use
much of drawCache and most of the assistant is drawn in the
drawAssistant() function. This most probably means lower
performance and it should probably be fixed by moving
drawing the static parts of the assistants into the drawCache()
function.
Related: bug 433097

M  +2    -2    plugins/assistants/Assistants/ParallelRulerAssistant.cc
M  +9    -7    plugins/assistants/Assistants/TwoPointAssistant.cc
M  +20   -17   plugins/assistants/Assistants/VanishingPointAssistant.cc

https://invent.kde.org/graphics/krita/commit/3f9634d312c8ec8c855e3a601b3b0517de618396
Comment 5 Bug Janitor Service 2021-10-09 04:35:56 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Bug Janitor Service 2021-10-24 04:35:31 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!