Bug 433097 - vanishing point assistant - option to set density to 0 pre-calculated guides
Summary: vanishing point assistant - option to set density to 0 pre-calculated guides
Status: RESOLVED WORKSFORME
Alias: None
Product: krita
Classification: Applications
Component: Tool/Assistants (other bugs)
Version First Reported In: 4.4.2
Platform: Microsoft Windows Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-17 17:55 UTC by barberapali
Modified: 2021-10-24 04:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
vanishing point density 180 (119.50 KB, image/jpeg)
2021-02-17 17:55 UTC, barberapali
Details
vp (68.01 KB, image/jpeg)
2021-02-17 17:56 UTC, barberapali
Details

Note You need to log in before you can comment on or make changes to this bug.
Description barberapali 2021-02-17 17:55:46 UTC
Created attachment 135775 [details]
vanishing point density 180

Would be great if there is an option to remove completely the pre-computed guides of vanishing points so the only guides remain the dynamically updated ones that will intersect at current cursor position.
See attached image for clarity, the minimum amount of pre-computed guides per vanishing point is currently 1 when you set the density to 180 degrees, 
Once you add multiple vanishing points (ascending/descending plane/ vp for shadows etc) you get a bunch of horizontal lines for every vp added that will stay horizontal in regards to screen while you rotate the canvas ... this will make it harder to guess what line goes where, especially when the precomputed horizontal guides  are nearly overlapped with the dynamically computed guides.

An option do disable completely the pre-computed guides would be awesome.

Otherwise the perspective guides are pretty awesome.
Thanks for this great piece of software.
Comment 1 barberapali 2021-02-17 17:56:48 UTC
Created attachment 135776 [details]
vp

horizontal lines are distracting and do not help much.
Comment 2 Tiar 2021-09-22 12:08:04 UTC
Git commit a2e402e02ce5cad685d4bf3fc6a3f55c27c34ff4 by Agata Cacko.
Committed on 22/09/2021 at 11:57.
Pushed by tymond into branch 'master'.

Fix assistants preview vs drawn assistant

Before this commit, some (especially new) assistants were confused
what is the preview (which can be disabled with View -> Show
Assistants Preview) and what is the assistant itself
(which can be disabled with View -> Show Painting Assistants).
This commit fixes it for three assistants:
- Parallel Ruler
- Vanishing Point
- Two Point Assistant

Previews: all moving parts (dependant on the mouse position)
Assistants: all static parts (independant on the mouse position)

Note that Two Point and Vanishing Point assistants don't use
much of drawCache and most of the assistant is drawn in the
drawAssistant() function. This most probably means lower
performance and it should probably be fixed by moving
drawing the static parts of the assistants into the drawCache()
function.
Related: bug 442102

M  +2    -2    plugins/assistants/Assistants/ParallelRulerAssistant.cc
M  +9    -7    plugins/assistants/Assistants/TwoPointAssistant.cc
M  +20   -17   plugins/assistants/Assistants/VanishingPointAssistant.cc

https://invent.kde.org/graphics/krita/commit/a2e402e02ce5cad685d4bf3fc6a3f55c27c34ff4
Comment 3 Tiar 2021-09-22 12:46:45 UTC
That comment is related to this bug report because now it's more reliable for assistants to disable the assistant view in View -> Show Painting Assistant. 

@barberapali if you turn off View -> Show Painting Assistant, does it solve your issue? It will disappear the static lines but won't disappear the preview (line from the vanishing point to your mouse).
Comment 4 Tiar 2021-09-24 13:49:09 UTC
Git commit 3f9634d312c8ec8c855e3a601b3b0517de618396 by Agata Cacko.
Committed on 24/09/2021 at 13:45.
Pushed by tymond into branch 'krita/5.0'.

Fix assistants preview vs drawn assistant

Before this commit, some (especially new) assistants were confused
what is the preview (which can be disabled with View -> Show
Assistants Preview) and what is the assistant itself
(which can be disabled with View -> Show Painting Assistants).
This commit fixes it for three assistants:
- Parallel Ruler
- Vanishing Point
- Two Point Assistant

Previews: all moving parts (dependant on the mouse position)
Assistants: all static parts (independant on the mouse position)

Note that Two Point and Vanishing Point assistants don't use
much of drawCache and most of the assistant is drawn in the
drawAssistant() function. This most probably means lower
performance and it should probably be fixed by moving
drawing the static parts of the assistants into the drawCache()
function.
Related: bug 442102

M  +2    -2    plugins/assistants/Assistants/ParallelRulerAssistant.cc
M  +9    -7    plugins/assistants/Assistants/TwoPointAssistant.cc
M  +20   -17   plugins/assistants/Assistants/VanishingPointAssistant.cc

https://invent.kde.org/graphics/krita/commit/3f9634d312c8ec8c855e3a601b3b0517de618396
Comment 5 Bug Janitor Service 2021-10-09 04:35:50 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Bug Janitor Service 2021-10-24 04:35:26 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!