Created attachment 141292 [details] Image comparing the same file with the same definition in two versions of krita SUMMARY The "Out of Gamut Warnings" doesn't work in Krita 5 beta 1. It Works normally on previous versions, including the latest stable 4.4.8 see attached image STEPS TO REPRODUCE 1. just activate the out of gamut warnings ( CTRL+SHIFT+Y ) 2. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Windows: 10 macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION
Could you please provide start-to-finish steps that would produce out-of-gamut warnings in Krita 4 and not in Krita 5? I'm not familiar with this feature (not a developer) but I could confirm it for you if I can reproduce the problem.
This is because of the fast float lcms plugin, which was broken. Some fixes were pushed to lcms today, and we will update our dependencies.
Same issue as 437429 (even if they look wildly different). When facing a linear RGB workflow, the LittleCMS fast float plugin disables optimizations only if the space is 16-bit integer, which is not correct for our use case. The fix has been sent upstream and will be incorporated as part of https://invent.kde.org/graphics/krita/-/merge_requests/1045. *** This bug has been marked as a duplicate of bug 437429 ***
Git commit 411297e62feb2d04c38182e2e5f3cab8361db46c by L. E. Segovia. Committed on 14/09/2021 at 14:29. Pushed by lsegovia into branch 'master'. LittleCMS: fix linearity check for 32-bit and floating point RGB Related: bug 437429 M +5 -5 3rdparty/ext_lcms2/0001-Add-cmake-build-system.patch M +3 -3 3rdparty/ext_lcms2/0002-Quick-check-for-SSE-support.patch M +4 -4 3rdparty/ext_lcms2/0003-Separate-fast-float-plugin.patch A +27 -0 3rdparty/ext_lcms2/0004-Linear-RGB-also-comes-in-32-bit-and-floating-point.patch https://invent.kde.org/graphics/krita/commit/411297e62feb2d04c38182e2e5f3cab8361db46c
Git commit 565c618bb0e0b18716e5b4637e5186d703c41f92 by L. E. Segovia. Committed on 14/09/2021 at 14:43. Pushed by lsegovia into branch 'krita/5.0'. LittleCMS: fix linearity check for 32-bit and floating point RGB Related: bug 437429, bug 439947 (cherry picked from commit 411297e62feb2d04c38182e2e5f3cab8361db46c) M +5 -5 3rdparty/ext_lcms2/0001-Add-cmake-build-system.patch M +3 -3 3rdparty/ext_lcms2/0002-Quick-check-for-SSE-support.patch M +4 -4 3rdparty/ext_lcms2/0003-Separate-fast-float-plugin.patch A +27 -0 3rdparty/ext_lcms2/0004-Linear-RGB-also-comes-in-32-bit-and-floating-point.patch https://invent.kde.org/graphics/krita/commit/565c618bb0e0b18716e5b4637e5186d703c41f92
Git commit cae8af720c388bda9007cf95ab760ee697e5cd9c by Halla Rempt, on behalf of L. E. Segovia. Committed on 20/09/2021 at 09:24. Pushed by rempt into branch 'master'. LittleCMS: fix linearity check with upstream update Related: bug 437429, bug 441366 D +0 -27 3rdparty/ext_lcms2/0004-Linear-RGB-also-comes-in-32-bit-and-floating-point.patch M +2 -2 3rdparty/ext_lcms2/CMakeLists.txt https://invent.kde.org/graphics/krita/commit/cae8af720c388bda9007cf95ab760ee697e5cd9c
Git commit 5548012a25362e3786cec812a312f5d57b523dd7 by L. E. Segovia. Committed on 21/09/2021 at 14:00. Pushed by lsegovia into branch 'krita/5.0'. LittleCMS: fix linearity check with upstream update Related: bug 437429, bug 441366 (cherry picked from commit cae8af720c388bda9007cf95ab760ee697e5cd9c) D +0 -27 3rdparty/ext_lcms2/0004-Linear-RGB-also-comes-in-32-bit-and-floating-point.patch M +2 -2 3rdparty/ext_lcms2/CMakeLists.txt https://invent.kde.org/graphics/krita/commit/5548012a25362e3786cec812a312f5d57b523dd7