Bug 441366 - L*a*b color model got broken in 5.0 beta1
Summary: L*a*b color model got broken in 5.0 beta1
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Color models (show other bugs)
Version: 5.0.0-beta1
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Lynx3d
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-08-22 14:21 UTC by Wojtek Trybus
Modified: 2021-09-21 14:01 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Document in L*a*b (123.06 KB, image/png)
2021-08-22 14:21 UTC, Wojtek Trybus
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wojtek Trybus 2021-08-22 14:21:29 UTC
Created attachment 140948 [details]
Document in L*a*b

SUMMARY
Creating a document in L*a*b or converting RGB document to this color model, causes the color selector to display and pick corrupted colors (available colors does not make sense - screenshot attached)

STEPS TO REPRODUCE
1. Create document in L*a*b

OBSERVED RESULTS:
corrupted color space as shown on screenshot

SOFTWARE/OS VERSIONS
Operating System: Kubuntu 20.04
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.68.0
Qt Version: 5.12.8
Kernel Version: 5.4.0-81-generic
OS Type: 64-bit
Processors: 16 × AMD Ryzen 7 2700 Eight-Core Processor
Memory: 31,4 GiB

ADDITIONAL INFORMATION
Also confirmed on Windows 10
Comment 1 Halla Rempt 2021-08-23 09:16:06 UTC
Wolthera, Lynx3d, I guess this is fall-out from the lcms issue?
Comment 2 wolthera 2021-08-23 13:31:33 UTC
yes it is, Lynx3d is already investigating it. It's a bug in LCMS though, and it seems Marti is on holiday right now.
Comment 3 Lynx3d 2021-08-23 15:22:31 UTC
Yes, I think I've located the issue in a pipeline optimization of LCMS, but unfortunately I don't know enough about it to propose a fix.

All I could do for now is report the issue upstream:
https://github.com/mm2/Little-CMS/issues/272
Comment 4 Bug Janitor Service 2021-09-08 18:04:21 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1045
Comment 5 amyspark 2021-09-14 14:41:42 UTC
Git commit ec72afa34b7e0060ff3c894d9e195dd82dc531a6 by L. E. Segovia.
Committed on 14/09/2021 at 14:29.
Pushed by lsegovia into branch 'master'.

Update LittleCMS to latest master

M  +2    -2    3rdparty/ext_lcms2/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/ec72afa34b7e0060ff3c894d9e195dd82dc531a6
Comment 6 amyspark 2021-09-14 14:44:07 UTC
Git commit 2c171fefa67a123a0c43f23b06d6363d63489ddf by L. E. Segovia.
Committed on 14/09/2021 at 14:43.
Pushed by lsegovia into branch 'krita/5.0'.

Update LittleCMS to latest master
(cherry picked from commit ec72afa34b7e0060ff3c894d9e195dd82dc531a6)

M  +2    -2    3rdparty/ext_lcms2/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/2c171fefa67a123a0c43f23b06d6363d63489ddf
Comment 7 Halla Rempt 2021-09-20 09:25:19 UTC
Git commit cae8af720c388bda9007cf95ab760ee697e5cd9c by Halla Rempt, on behalf of L. E. Segovia.
Committed on 20/09/2021 at 09:24.
Pushed by rempt into branch 'master'.

LittleCMS: fix linearity check with upstream update
Related: bug 442004, bug 437429

D  +0    -27   3rdparty/ext_lcms2/0004-Linear-RGB-also-comes-in-32-bit-and-floating-point.patch
M  +2    -2    3rdparty/ext_lcms2/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/cae8af720c388bda9007cf95ab760ee697e5cd9c
Comment 8 amyspark 2021-09-21 14:01:21 UTC
Git commit 5548012a25362e3786cec812a312f5d57b523dd7 by L. E. Segovia.
Committed on 21/09/2021 at 14:00.
Pushed by lsegovia into branch 'krita/5.0'.

LittleCMS: fix linearity check with upstream update
Related: bug 442004, bug 437429
(cherry picked from commit cae8af720c388bda9007cf95ab760ee697e5cd9c)

D  +0    -27   3rdparty/ext_lcms2/0004-Linear-RGB-also-comes-in-32-bit-and-floating-point.patch
M  +2    -2    3rdparty/ext_lcms2/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/5548012a25362e3786cec812a312f5d57b523dd7