Created attachment 140254 [details] Initial view SUMMARY Incorrect total size of a partition is shown in Initial view of filelight app. My PC has /dev/sda2 partition of 867.39 GiB, but in Initial view of filelight app total size is shown as 852.8 GiB which is 14.59 GiB less. Please see the attached screenshot. output of lsblk: sda 8:0 0 931.5G 0 disk ├─sda1 8:1 0 129M 0 part /boot/efi ├─sda2 8:2 0 867.4G 0 part / ├─sda3 8:3 0 16M 0 part └─sda4 8:4 0 64G 0 part EXPECTED RESULT Correct size of /dev/sda2 partition of 867.39 GiB is shown instead of 852.8 GiB in Initial view of filelight app. SOFTWARE/OS VERSIONS Operating System: KDE neon 5.22 KDE Plasma Version: 5.22.3 KDE Frameworks Version: 5.84.0 Qt Version: 5.15.3 Kernel Version: 5.8.0-63-generic (64-bit) Graphics Platform: X11 Processors: 4 × Intel® Core™ i3-5010U CPU @ 2.10GHz Memory: 3.8 GiB of RAM Graphics Processor: Mesa Intel® HD Graphics 5500
Git commit 38a71d1cbd46964f47eac1377788ebaabc5956d8 by Harald Sitter. Committed on 19/04/2022 at 13:32. Pushed by sitter into branch 'master'. replace previous summary with tidy overview widget it occurred to us that the old disk view was fishy on a number of levels - it had a non exhaustive filter list of bad mounts - this then raised the question why the mounts are missing (when e.g. the user expected them to be there) - the free space on a partition is not reflective of the space filelight will be able to determine the use of (e.g. when +x is missing on a dir that dir will be missing from the fileview) - when talking about bind mounts (such as inside a sandbox) the two sizes will almost never add up - when inside a sandbox potentially only one valid path is available ($home) so having the previous view was slightly weird the grand new overview widget simply displays three buttons to get right into scanning root, home, or a custom path. root is hidden inside a sandbox. this preserves most of the spirit of what the previous view wanted to do while scaling better and doing away with judgment calls on the edge cases such as bind mounts Related: bug 452275, bug 440151, bug 426594 M +1 -0 CMakeLists.txt M +2 -2 src/CMakeLists.txt M +24 -28 src/mainWindow.cpp M +4 -4 src/mainWindow.h A +71 -0 src/overviewWidget.cpp [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)] A +23 -0 src/overviewWidget.h [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)] M +0 -2 src/radialMap/labels.cpp M +1 -28 src/radialMap/map.cpp M +1 -2 src/radialMap/map.h M +2 -3 src/radialMap/widget.cpp M +1 -6 src/radialMap/widget.h M +22 -43 src/radialMap/widgetEvents.cpp D +0 -183 src/summaryWidget.cpp D +0 -40 src/summaryWidget.h https://invent.kde.org/utilities/filelight/commit/38a71d1cbd46964f47eac1377788ebaabc5956d8