Bug 426594 - Some excluded folders are still scanned
Summary: Some excluded folders are still scanned
Status: RESOLVED FIXED
Alias: None
Product: filelight
Classification: Applications
Component: general (other bugs)
Version First Reported In: 20.08
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Martin Sandsmark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-16 09:33 UTC by Filip Majetić
Modified: 2022-04-19 13:59 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Majetić 2020-09-16 09:33:44 UTC
SUMMARY
Folders are still displayed on the initial screen, even when added to the "Do not scan these folders" list.
This happens when the folder itself is excluded, or its parent folder.

STEPS TO REPRODUCE
1. Add a folder that is visible on the initial screen, like /boot/efi, to the ignored folder list
2. Relaunch Filelight

OBSERVED RESULT
The /boot/efi folder is still displayed in the initial window

EXPECTED RESULT
The /boot/efi folder should not be shown

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.19.5
KDE Frameworks Version: 5.73.0
Qt Version: 5.1.50
Comment 1 Justin Zobel 2020-11-12 23:48:55 UTC
Confirmed on filelight 21.03.70
Comment 2 Harald Sitter 2022-04-19 13:59:01 UTC
Git commit 38a71d1cbd46964f47eac1377788ebaabc5956d8 by Harald Sitter.
Committed on 19/04/2022 at 13:32.
Pushed by sitter into branch 'master'.

replace previous summary with tidy overview widget

it occurred to us that the old disk view was fishy on a number of levels

- it had a non exhaustive filter list of bad mounts
- this then raised the question why the mounts are missing (when e.g.
the user expected them to be there)
- the free space on a partition is not reflective of the space filelight
will be able to determine the use of (e.g. when +x is missing on a dir
that dir will be missing from the fileview)
- when talking about bind mounts (such as inside a sandbox) the two
sizes will almost never add up
- when inside a sandbox potentially only one valid path is available
($home) so having the previous view was slightly weird

the grand new overview widget simply displays three buttons to get right
into scanning root, home, or a custom path. root is hidden inside a
sandbox.

this preserves most of the spirit of what the previous view wanted to do
while scaling better and doing away with judgment calls on the edge
cases such as bind mounts
Related: bug 452275, bug 440152, bug 440151

M  +1    -0    CMakeLists.txt
M  +2    -2    src/CMakeLists.txt
M  +24   -28   src/mainWindow.cpp
M  +4    -4    src/mainWindow.h
A  +71   -0    src/overviewWidget.cpp     [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)]
A  +23   -0    src/overviewWidget.h     [License: GPL(3+eV) GPL(v3.0) GPL(v2.0)]
M  +0    -2    src/radialMap/labels.cpp
M  +1    -28   src/radialMap/map.cpp
M  +1    -2    src/radialMap/map.h
M  +2    -3    src/radialMap/widget.cpp
M  +1    -6    src/radialMap/widget.h
M  +22   -43   src/radialMap/widgetEvents.cpp
D  +0    -183  src/summaryWidget.cpp
D  +0    -40   src/summaryWidget.h

https://invent.kde.org/utilities/filelight/commit/38a71d1cbd46964f47eac1377788ebaabc5956d8