Bug 437567 - Provide Remove Warning when Only One Language is Available
Summary: Provide Remove Warning when Only One Language is Available
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_language (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Eike Hein
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2021-05-23 17:45 UTC by Andres Betts
Modified: 2021-05-28 22:31 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.22
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Betts 2021-05-23 17:45:46 UTC
Currently the language setting shows one language available in the system. If the user clicks the remove button, nothing happens. While this may be a good indication that the default language cannot be removed, it would be a stronger message if the user received a warning. For example,

"The default language cannot be removed. Add more languages, select a new default and then remove this language."

This could be as an in-kcm warming or maybe a popup instead. The user should receive more intentional information about why the remove action doesn't work.
Comment 1 Nicolas Fella 2021-05-23 19:30:33 UTC
Would it make sense to just disable the remove action?
Comment 2 Andres Betts 2021-05-23 21:19:33 UTC
It would make sense. Yeah. I would still include language showing the process somewhere in the window.
Comment 3 Nate Graham 2021-05-26 17:56:01 UTC
Yes, we should just hide the remove action when only one language is present.
Comment 4 Bug Janitor Service 2021-05-26 20:23:29 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/892
Comment 5 Nate Graham 2021-05-28 22:30:34 UTC
Git commit c6c4c9adf528d2869db7708296fcb721b88d93e7 by Nate Graham.
Committed on 28/05/2021 at 22:30.
Pushed by ngraham into branch 'master'.

[kcms/translations] Be more consistent with inline remove buttons

To be consistent with what we generally do in other places, use the
trashcan icon for the remove button, and only show it when the list has
more than one item in it.
Related: bug 437566
FIXED-IN: 5.22

M  +2    -1    kcms/translations/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/c6c4c9adf528d2869db7708296fcb721b88d93e7
Comment 6 Nate Graham 2021-05-28 22:31:01 UTC
Git commit b3a04fc0e172f779fc2e2eca9534996054eb922a by Nate Graham.
Committed on 28/05/2021 at 22:30.
Pushed by ngraham into branch 'Plasma/5.22'.

[kcms/translations] Be more consistent with inline remove buttons

To be consistent with what we generally do in other places, use the
trashcan icon for the remove button, and only show it when the list has
more than one item in it.
Related: bug 437566
FIXED-IN: 5.22


(cherry picked from commit c6c4c9adf528d2869db7708296fcb721b88d93e7)

M  +2    -1    kcms/translations/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/b3a04fc0e172f779fc2e2eca9534996054eb922a