Bug 437566 - Use Consistent Remove Icon
Summary: Use Consistent Remove Icon
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_language (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-23 17:42 UTC by Andres Betts
Modified: 2021-05-28 22:31 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.22
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Betts 2021-05-23 17:42:16 UTC
Consider changing the remove icon to be an X or the trashcan icon. I think we might need to make a remove icon standard throughout system settings.
Comment 1 Nicolas Fella 2021-05-23 19:06:44 UTC
See https://phabricator.kde.org/T12777 for discussion
Comment 2 Nicolas Fella 2021-05-24 14:10:07 UTC
Does https://invent.kde.org/plasma/kwin/-/merge_requests/995 satisfy this?
Comment 3 Nate Graham 2021-05-26 18:16:54 UTC
For the Virtual Desktops KCM, yes. This appears to be about the Language KCM though.
Comment 4 Bug Janitor Service 2021-05-26 20:23:29 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/892
Comment 5 Nate Graham 2021-05-28 22:30:26 UTC
Git commit c6c4c9adf528d2869db7708296fcb721b88d93e7 by Nate Graham.
Committed on 28/05/2021 at 22:30.
Pushed by ngraham into branch 'master'.

[kcms/translations] Be more consistent with inline remove buttons

To be consistent with what we generally do in other places, use the
trashcan icon for the remove button, and only show it when the list has
more than one item in it.
Related: bug 437567
FIXED-IN: 5.22

M  +2    -1    kcms/translations/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/c6c4c9adf528d2869db7708296fcb721b88d93e7
Comment 6 Nate Graham 2021-05-28 22:31:09 UTC
Git commit b3a04fc0e172f779fc2e2eca9534996054eb922a by Nate Graham.
Committed on 28/05/2021 at 22:30.
Pushed by ngraham into branch 'Plasma/5.22'.

[kcms/translations] Be more consistent with inline remove buttons

To be consistent with what we generally do in other places, use the
trashcan icon for the remove button, and only show it when the list has
more than one item in it.
Related: bug 437567
FIXED-IN: 5.22


(cherry picked from commit c6c4c9adf528d2869db7708296fcb721b88d93e7)

M  +2    -1    kcms/translations/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/b3a04fc0e172f779fc2e2eca9534996054eb922a