Bug 435533 - Keyboard layout change OSD no longer appears on X11 when switching using "Alternative shortcut"
Summary: Keyboard layout change OSD no longer appears on X11 when switching using "Alt...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Keyboard Layout (show other bugs)
Version: 5.20.90
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: 1.0
Assignee: Andrey
URL: https://invent.kde.org/plasma/plasma-...
Keywords: regression
: 437504 437512 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-04-09 05:07 UTC by Chromer
Modified: 2021-06-01 15:22 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.22


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chromer 2021-04-09 05:07:35 UTC
SUMMARY

After the upgrade to Plasma 5.21, there is no longer a visual cue after I change the layout using the keyboard shortcuts. The one in the taskbar still changes properly, but the usual popup doesn't appear. The other popups, e.g. volume and brightness, work fine.
It happens only on X11, on wayland it's ok and working like charm.

STEPS TO REPRODUCE
1. Start Plasma on X11 session.
2. Change layout with keyboard shortcut
3. And no visual cue !

OBSERVED RESULT


EXPECTED RESULT
To show a visual cue when changing layout.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 5.21.4
KDE Frameworks Version: 5.80
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Andrey 2021-04-09 14:26:24 UTC
Do you use "custom" shortcuts to switch layout? I mean, how you configure them?
Because for ones in Keyboard KCM Advanced tab that never worked on X11 before.
Comment 2 Nate Graham 2021-04-09 20:03:33 UTC
Works on Wayland, known virtually unfixable bug on X11. :(

*** This bug has been marked as a duplicate of bug 408928 ***
Comment 3 Andrey 2021-04-09 20:15:34 UTC
(In reply to Nate Graham from comment #2)
> Works on Wayland, known virtually unfixable bug on X11. :(
> 
> *** This bug has been marked as a duplicate of bug 408928 ***
This is different.

From https://bugs.kde.org/show_bug.cgi?id=408928#c7:
"I see a similar behaviour (no OSD), but only when the keyboard shortcut is from the "main" shortcut list. If I switch keyboards using a user-defined "alternative" shortcut, the OSD appears."

Whereas now we seem don't have OSD in both shortcut cases - thus, a regression.
Comment 4 Chromer 2021-04-10 10:05:45 UTC
(In reply to Andrey from comment #1)
> Do you use "custom" shortcuts to switch layout? I mean, how you configure
> them?
> Because for ones in Keyboard KCM Advanced tab that never worked on X11
> before.

No, I use ALT+SHIFT available by default in settings.
Comment 5 Chromer 2021-04-10 10:06:39 UTC
(In reply to Nate Graham from comment #2)
> Works on Wayland, known virtually unfixable bug on X11. :(
> 
> *** This bug has been marked as a duplicate of bug 408928 ***

But we had not this bug on 5.20 ! :( :( :(
Comment 6 Andrey 2021-04-15 23:38:30 UTC
I suppose you are speaking about Alternative shortcut in KCM for changing layout.
Because for Main shortcut, it never worked on X11.
Comment 7 Andrey 2021-04-17 18:02:43 UTC
Probable reason:
https://invent.kde.org/plasma/plasma-desktop/-/commit/9021b3cb4d597413daa8f9960a0b69524fb77715?merge_request_iid=293

Thanks for reporting, I forgot about it.
Comment 8 Andrey 2021-04-18 14:32:23 UTC
I admit this is a regression but let's truck it in the upstream bug indeed, as the solution should be common (and I have an idea how to fix it)

*** This bug has been marked as a duplicate of bug 408928 ***
Comment 9 Andrey 2021-05-22 23:10:25 UTC
*** Bug 437512 has been marked as a duplicate of this bug. ***
Comment 10 Andrey 2021-05-22 23:17:33 UTC
*** Bug 437504 has been marked as a duplicate of this bug. ***
Comment 11 Andrey 2021-06-01 09:52:27 UTC
Long standing bug 408928 is much more trickier to fix, so let's track it separately.
Sorry for the noise.
Comment 12 Bug Janitor Service 2021-06-01 09:57:33 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/493
Comment 13 Andrey 2021-06-01 10:42:49 UTC
Git commit 7ff6711523f2ec18e117a39598398e3598b54d18 by Andrey Butirsky, on behalf of David Edmundson.
Committed on 01/06/2021 at 10:42.
Pushed by butirsky into branch 'master'.

[kcms/keyboard] Restore keyboard layout OSD on X11

OSD for alternative shortcut has been removed in 9021b3cb, because that
approach didn't work well with new layout applet.

Here we restore it with original behavior - the OSD is shown when the
shortcut is invoked, but not when used via the applet.

M  +12   -1    kcms/keyboard/keyboard_daemon.cpp

https://invent.kde.org/plasma/plasma-desktop/commit/7ff6711523f2ec18e117a39598398e3598b54d18
Comment 14 Andrey 2021-06-01 10:44:51 UTC
Git commit ec98b22b58e61eb887ddb0455beacb04e6faf94a by Andrey Butirsky, on behalf of David Edmundson.
Committed on 01/06/2021 at 10:44.
Pushed by butirsky into branch 'Plasma/5.22'.

[kcms/keyboard] Restore keyboard layout OSD on X11

OSD for alternative shortcut has been removed in 9021b3cb, because that
approach didn't work well with new layout applet.

Here we restore it with original behavior - the OSD is shown when the
shortcut is invoked, but not when used via the applet.


(cherry picked from commit 7ff6711523f2ec18e117a39598398e3598b54d18)

M  +12   -1    kcms/keyboard/keyboard_daemon.cpp

https://invent.kde.org/plasma/plasma-desktop/commit/ec98b22b58e61eb887ddb0455beacb04e6faf94a
Comment 15 Andrey 2021-06-01 10:46:56 UTC
Git commit d2ff6eb331d3853f691367055a177eb3fdd13a0c by Andrey Butirsky, on behalf of David Edmundson.
Committed on 01/06/2021 at 10:46.
Pushed by butirsky into branch 'Plasma/5.21'.

[kcms/keyboard] Restore keyboard layout OSD on X11

OSD for alternative shortcut has been removed in 9021b3cb, because that
approach didn't work well with new layout applet.

Here we restore it with original behavior - the OSD is shown when the
shortcut is invoked, but not when used via the applet.


(cherry picked from commit 7ff6711523f2ec18e117a39598398e3598b54d18)

M  +12   -1    kcms/keyboard/keyboard_daemon.cpp

https://invent.kde.org/plasma/plasma-desktop/commit/d2ff6eb331d3853f691367055a177eb3fdd13a0c
Comment 16 Andrey 2021-06-01 14:59:52 UTC
Does it mean there will be no more 5.21 bugfix releases, Nate?
Comment 17 Nate Graham 2021-06-01 15:22:58 UTC
Yeah. The last 5.21 release was 5.21.5, which was shipped a few weeks ago.

See https://community.kde.org/Schedules/Plasma_5