Bug 434709 - wrong xhtml script element parsing
Summary: wrong xhtml script element parsing
Status: REPORTED
Alias: None
Product: Falkon
Classification: Applications
Component: general (other bugs)
Version First Reported In: 3.1.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-21 11:33 UTC by kavol
Modified: 2021-03-21 23:02 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kavol 2021-03-21 11:33:54 UTC
Trying reproducer for bug 196868 (attachment 34606 [details]) I have found that Falkon doesn't display the page at all.

Trying the inspector, it shows empty body. Unfolding the head, I see all the contents of the body inserted _into_ the last head element which is a script tag.

Obviously, the browser completely ignores the fact that the script tag is closed.


STEPS TO REPRODUCE
1. wget -O reproducer.tgz https://bugs.kde.org/attachment.cgi?id=34606
2. tar xzf reproducer.tgz
3. falkon index.html

OBSERVED RESULT
empty page

EXPECTED RESULT
normal page, with some text displayed

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 5.20.5
KDE Frameworks Version: 5.77.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Trying to upload the page onto W3C validator (validator.w3.org), it reports the code as valid, no mismatched tags - if I remove the closing slash from the script tag to simulate what happens in the browser's parser, it reports that the closing tag is omitted.
Comment 1 Juraj 2021-03-21 17:35:31 UTC
Hello,
I tried this with Chromium and I got the same results.
Can you confirm that?

In that case this issue could be closed and marked as upstream since it originates in Chromium itself.
Comment 2 kavol 2021-03-21 23:02:26 UTC
(In reply to Juraj from comment #1)
> Hello,
> I tried this with Chromium and I got the same results.
> Can you confirm that?
>
> In that case this issue could be closed and marked as upstream since it
> originates in Chromium itself.

pardon my ignorance, but what has Falkon to do with Chromium?

I thought it uses QtWebEngine, so if the problem originates with code provided by Qt, it should be reported to Qt

if Qt copies the code from elsewhere, then Qt should forward it to the origin

if you're saying there is a shortcut, well, okay, then go ahead and report the problem where do you deem appropriate, but then we're losing track when will the fix hit downstream, if ever

anyways, I'm just simple Falkon user, I see a problem when using Falkon, so from my POV, your attitude "not in our code, so just close this" really does not help to get rid of the problem - sorry if I got you wrong, I do not mean this negatively, I'm just trying to express myself that I just want to use the product and do not spend time studying its internals when you already know; well, to be honest, I believe I've already did my part by identifying the exact issue and reporting it, so that other users can benefit from the fix (if it gets fixed, but without even knowing the problem it can hardly go magically away itself) instead of swearing what a crappy product Falkon is, not displaying something ...