Created attachment 135769 [details]
visualisation of issue
The "Global theme" item under "Appearence" becomes the top-level menu item. While other Settings options show the title for that section e.g. "Workspace"
STEPS TO REPRODUCE
1. Open system settings full-screen
2. Navigate to appearance
Global theme is the top-level menu item coloured in the header title colours.
Operating System: openSUSE Tumbleweed 20210215
KDE Plasma Version: 5.21.0
KDE Frameworks Version: 5.78.0
Qt Version: 5.15.2
Kernel Version: 5.10.16-1-default
Graphics Platform: Wayland
This was an intentional change in Plasma 5.21. The idea was to show that all of the other pages are children of this page (since they are).
Hmm. It is not consistent across other settings. But alas.
Consistency would actually be inconsistent in this case, because no other pages have both content of their own, and also child pages. The Global Themes page is presented differently because it *is* different. :)
*** Bug 433312 has been marked as a duplicate of this bug. ***
FWIW we are not super satisfied with this presentation but were unable to come up with anything better. The idea is to communicate that Global Themes is the "parent" page and all the other pages are children, without hiding the child pages and making them too inaccessible.
Suggestions are welcome.
Hello Nate, thanks for linking my duplicate. However I can understand that the behavior is intentional, it has usability issues.
- Inconsistency: When I click the menu item labeled "Appearance", I expect the 2nd level caption is "Appearance".
- Confusion: When I walk through the 2nd level menu items, I miss "Global Theme" there. I do not expect the caption to be clickable.
Making the item "Global Theme" a caption and removing it from 2nd level menu items made it IMO less visible. The previous UX worked well for me, nevertheless I respect your decision.
The previous UI was definitely consistent, but it failed to communicate something important: That Global Themes is a parent of all the other pages, such that changing the Global Theme will affect the value of all the other pages.
I understand that you don't think the new UI really succeeds at this, and I even kind of agree. However that just means we need to change it to something better, because we really do want to communicate that relationship somehow in the UI.
I'll re-open this and we can discuss potential improvements or alternatives here.
Also this change caused us to lose clickability on the whole header text to go back, generating a bug report: Bug 433202.
The label "Appearance" covers the content properly. So I don't understand the need to show-case that "global theme" relates to all sub settings. That is kind of covered by the name itself. What may help is that the header name is "Appearance" and the first item "Global Theme" with a hover explaining that changing the global theme touches all appearance related settings. Maybe a re-label to "Global Appearance" helps in clearly stating that it touches everything.
As by nature of the settings menu it is not entirely different behaviour using the global themes, that warrants this different behaviour.
> So I don't understand the need to show-case that "global theme" relates to
> all sub settings
The reason is because we have users confused about this relationship. We want to communicate that changing a global theme can (and often does) change all of the child settings.
A hover tooltip won't really work because you would only see it when hovering over that entry. We generally don't use tooltips for very important information.
(In reply to Nate Graham from comment #10)
> The reason is because we have users confused about this relationship. We
> want to communicate that changing a global theme can (and often does) change
> all of the child settings.
As an user I did not get such message, sorry. I just noticed "hey, the most important menu item is missing here". As I understand your intention now, the arrangement is still confusing to me.
How about a simple colorful rectangle on top of the theme-list with few words of explanation? I can see some red rectangles in systemsettings modules for touchpad or joystick. Maybe we can use these in different color?
Yeah, I understand that the approach we took doesn't seem to have actually worked. :)
In global settings it appears non consistent, see attached image.
Created attachment 136280 [details]
Appearance header empty
That's an unrelated issue: Bug 433621.
*** Bug 433853 has been marked as a duplicate of this bug. ***
Marking as VHI as we are getting a lot of user complaints about this.
To add to the confusion. If you don't have system settings full-screen and click on appearance, you only have global theme as the menu is not navigating to the next level as with "workspace behaviour". You have to click appearance for a second time to move into the next level.
Disregard the above. It does go down, but had a glitch (or 2).
Git commit 80f7c06166a095cfa144d7664951e29210e7c89c by Marco Martin.
Committed on 23/03/2021 at 15:26.
Pushed by mart into branch 'master'.
make the modules look indented
if a subcategory has a category owner module, make
them look indented to suggest they are logical
children of the category owner module
Related: bug 433202
M +8 -1 app/SettingsBase.cpp
M +12 -2 core/MenuItem.cpp
M +6 -0 core/MenuItem.h
M +13 -1 core/MenuModel.cpp
M +4 -2 sidebar/SidebarMode.cpp
M +38 -59 sidebar/package/contents/ui/SubCategoryPage.qml
*** Bug 436183 has been marked as a duplicate of this bug. ***