Bug 432245 - breeze-gtk has stepper buttons in gtk3 apps
Summary: breeze-gtk has stepper buttons in gtk3 apps
Status: VERIFIED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: 5.20.90
Platform: Other Linux
: VHI normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-01-28 12:08 UTC by pmargeti34
Modified: 2021-02-11 14:43 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21


Attachments
no steppers with 5.20.5 (254.94 KB, image/png)
2021-01-29 16:08 UTC, pmargeti34
Details
steppers with 5.20.90 and disabled css workaround (356.72 KB, image/png)
2021-01-29 16:09 UTC, pmargeti34
Details
bonus round gnome termial (291.19 KB, image/png)
2021-01-29 16:09 UTC, pmargeti34
Details

Note You need to log in before you can comment on or make changes to this bug.
Description pmargeti34 2021-01-28 12:08:15 UTC
SUMMARY

breeze-gtk has stepper buttons in Firefox

STEPS TO REPRODUCE
1. update to breeze-gtk 5.20.90
2. launch firefox
3. find a scrollable page

OBSERVED RESULT
firefox displays scrollbar with stepper buttons

EXPECTED RESULT
stepper buttons aren't displayed

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Archlinux
(available in About System)
KDE Plasma Version: 5.20.90
KDE Frameworks Version: 5.78
Qt Version: 5.15.2

ADDITIONAL INFORMATION
downgrading to breeze-gtk 5.20.5 displays the scrollbars in gtk apps without stepper buttons
Comment 1 Nate Graham 2021-01-28 21:53:55 UTC
Do your KDE apps' scrollbars have stepper buttons?
Comment 2 pmargeti34 2021-01-29 00:50:42 UTC
(In reply to Nate Graham from comment #1)
> Do your KDE apps' scrollbars have stepper buttons?

Negative.
Comment 3 pmargeti34 2021-01-29 00:52:55 UTC
I've added this to gtk.css in my .config directory
```
~ ▶ cat .config/gtk-3.0/gtk.css
@import 'colors.css';
scrollbar {
  -GtkScrollbar-has-backward-stepper: false;
  -GtkScrollbar-has-forward-stepper: false;
  background-color: transparent;
}
```
This makes it work, but for some reason this isn't read from breeze gtk theme directly
Downgrading to 5.20.5 makes it work too.
For now I'm keeping the package locked for updates. 5.20.90 is also suffering from huge menus and gnome-terminal displays the close button all kinds of wrong with it. Very buggy!
Comment 4 David Redondo 2021-01-29 10:45:50 UTC
Info was provided
Comment 5 Nate Graham 2021-01-29 15:48:31 UTC
Weird. Works for me.

> huge menus
Yeah this is a known bug: Bug 431819.
Comment 6 pmargeti34 2021-01-29 16:08:46 UTC
Created attachment 135283 [details]
no steppers with 5.20.5
Comment 7 pmargeti34 2021-01-29 16:09:17 UTC
Created attachment 135284 [details]
steppers with 5.20.90 and disabled css workaround
Comment 8 pmargeti34 2021-01-29 16:09:38 UTC
Created attachment 135285 [details]
bonus round gnome termial
Comment 9 pmargeti34 2021-01-29 16:10:23 UTC
(In reply to Nate Graham from comment #5)
> Weird. Works for me.
> 
I'm glad for you :D But it doesn't work for me :sadface:
Comment 10 Nate Graham 2021-02-07 15:14:47 UTC
Sorry, I was not testing properly. I can reproduce the issue now.

Jan, can you take a look before final tagging in 4 days? Thanks!
Comment 11 pmargeti34 2021-02-07 15:45:31 UTC
(In reply to Nate Graham from comment #10)
> Sorry, I was not testing properly. I can reproduce the issue now.

no worries, considering how much work you're putting into making KDE ecosystem better, I can totally understand if mistakes happen
Comment 12 Janet Blackquill 2021-02-10 22:43:29 UTC
Git commit 7654db571f4130c2f4a0a4d0c6d4c63b06374a34 by Jan Blackquill.
Committed on 10/02/2021 at 22:43.
Pushed by cblack into branch 'master'.

Fix breakages caused by formatter run

The formatter run made many case-sensitive properties lowercase,
which caused a variety of bugs.

M  +11   -11   src/gtk3/widgets/_base.scss
M  +1    -1    src/gtk3/widgets/_headerbar.scss
M  +1    -1    src/gtk3/widgets/_menus.scss
M  +4    -4    src/gtk3/widgets/_scrollbar.scss
M  +1    -1    src/gtk3/widgets/_toolbar.scss
M  +5    -5    src/gtk3/widgets/_treeview.scss

https://invent.kde.org/plasma/breeze-gtk/commit/7654db571f4130c2f4a0a4d0c6d4c63b06374a34
Comment 13 Janet Blackquill 2021-02-10 22:44:18 UTC
Git commit d7550232f03cf503e067d757428b81c4eca49c2b by Jan Blackquill.
Committed on 10/02/2021 at 22:44.
Pushed by cblack into branch 'Plasma/5.21'.

Fix breakages caused by formatter run

The formatter run made many case-sensitive properties lowercase,
which caused a variety of bugs.
FIXED-IN: 5.21

(cherry picked from commit 7654db571f4130c2f4a0a4d0c6d4c63b06374a34)

M  +11   -11   src/gtk3/widgets/_base.scss
M  +1    -1    src/gtk3/widgets/_headerbar.scss
M  +1    -1    src/gtk3/widgets/_menus.scss
M  +4    -4    src/gtk3/widgets/_scrollbar.scss
M  +1    -1    src/gtk3/widgets/_toolbar.scss
M  +5    -5    src/gtk3/widgets/_treeview.scss

https://invent.kde.org/plasma/breeze-gtk/commit/d7550232f03cf503e067d757428b81c4eca49c2b
Comment 14 Nate Graham 2021-02-11 14:43:23 UTC
Yay thanks!