Bug 431819 - Menu items in GTK apps are larger than they are in Qt/KDE apps
Summary: Menu items in GTK apps are larger than they are in Qt/KDE apps
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: unspecified
Platform: Other Linux
: VHI normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-01-19 16:26 UTC by Fabian Vogt
Modified: 2021-02-02 20:00 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Vogt 2021-01-19 16:26:42 UTC
Found by openQA: https://openqa.opensuse.org/tests/1593459#step/firefox/14

As can be seen in firefox, menu items in the menu bar and submenus have giant margins.

Qt menus don't seem to be affected: https://openqa.opensuse.org/tests/1593460#step/live_installation/16 https://openqa.opensuse.org/tests/1593459#step/kontact/13
Comment 1 Nate Graham 2021-01-26 05:40:35 UTC
This was an intentional change to match the taller menu item heights in the Breeze qstyle.

I suspect if I close this, the response will be "menu items are too tall!" so I'll keep it open for now to see how many duplicates or complaints we get.
Comment 2 Fabian Vogt 2021-01-26 07:49:08 UTC
(In reply to Nate Graham from comment #1)
> This was an intentional change to match the taller menu item heights in the
> Breeze qstyle.

In Qt applications, the menu bar is 30px tall and items also 30px.
In Firefox, the menu bar is 37px tall and items 40px.

So Breeze-GTK menus are 33% bigger than Breeze.
Comment 3 Nate Graham 2021-01-26 15:50:11 UTC
Gotcha.
Comment 4 Nate Graham 2021-01-29 15:48:58 UTC
Raising to VHI as we're gonna get a lot of bug reports about this if we ship 5.21 with it.
Comment 5 Janet Blackquill 2021-02-02 20:00:11 UTC
Git commit 74602eee7e8066e85284c355fd061ca12864db82 by Jan Blackquill.
Committed on 02/02/2021 at 20:00.
Pushed by cblack into branch 'master'.

Adjust menu heights to properly match Breeze QStyle

Currently they're four pixels too tall, which means we need to shrink
vertical padding by two pixels.

M  +1    -1    src/gtk3/widgets/_menus.scss
M  +1    -1    src/gtk4/widgets/_menus.scss

https://invent.kde.org/plasma/breeze-gtk/commit/74602eee7e8066e85284c355fd061ca12864db82
Comment 6 Janet Blackquill 2021-02-02 20:00:40 UTC
Git commit 1f9e15a66c61f3f521fc593775f50b2d0ef68d72 by Jan Blackquill.
Committed on 02/02/2021 at 20:00.
Pushed by cblack into branch 'Plasma/5.21'.

Adjust menu heights to properly match Breeze QStyle

Currently they're four pixels too tall, which means we need to shrink
vertical padding by two pixels.
FIXED-IN: 5.21

M  +1    -1    src/gtk3/widgets/_menus.scss
M  +1    -1    src/gtk4/widgets/_menus.scss

https://invent.kde.org/plasma/breeze-gtk/commit/1f9e15a66c61f3f521fc593775f50b2d0ef68d72