Bug 431286 - 45e0a722fb85bb5d1ab8bef92080e934254b13aa (plasma-workspace) breaks showing lock screen UI by typing
Summary: 45e0a722fb85bb5d1ab8bef92080e934254b13aa (plasma-workspace) breaks showing lo...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: master
Platform: Other Linux
: VHI normal
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords: regression
: 431427 431966 432028 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-01-08 01:55 UTC by Nate Graham
Modified: 2021-01-24 13:00 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2021-01-08 01:55:38 UTC
Presumably because an invisible item can't have focus. I guess we need something to intercept keystrokes that *is* visible.
Comment 1 David Edmundson 2021-01-08 12:30:48 UTC
>        property bool blockUI: mainStack.depth > 1 || mainBlock.mainPasswordBox.text.length > 0 || inputPanel.keyboardActive


Heh, it's here. We were actually using whether the text box has text to clear the "screensaver"

Given were doing that, we can't drop the focus. 

I'll rework to do something like Fabian's patch.
Comment 2 Bug Janitor Service 2021-01-08 12:41:44 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/561
Comment 3 David Edmundson 2021-01-10 22:57:37 UTC
Git commit 2cbd7e4c70d0592d16cdaf58ed43effe4a716aa4 by David Edmundson.
Committed on 10/01/2021 at 22:54.
Pushed by davidedmundson into branch 'master'.

[lookandfeel] Fix wake existing screensaver mode with key presses

In commit 45e0a722fb85bb5d1ab8bef92080e934254b13aa we changed the focus
on the textfield with the intention of fixing the cusor blinking.

This had the unfortunate side effect of breaking waking out of the
screensaver mode with just the keyboard.

That screensaver mode was bound to:
```
property bool blockUI: mainBlock.mainPasswordBox.text.length > 0
```
for that to change, we need to have focus.

Instead this patches cursor blinking more explicity.

Doing it only in the lock screen (as opposed to the toolkit) makes sense
as this only happens due to somewhat unusual usage inside the
lockscreen.

M  +0    -3    lookandfeel/contents/lockscreen/LockScreenUi.qml
M  +6    -0    lookandfeel/contents/lockscreen/MainBlock.qml

https://invent.kde.org/plasma/plasma-workspace/commit/2cbd7e4c70d0592d16cdaf58ed43effe4a716aa4
Comment 4 Nate Graham 2021-01-11 01:17:32 UTC
Git commit 13057013d55ae19e76d29b9edc96510e52da2a7a by Nate Graham, on behalf of David Edmundson.
Committed on 11/01/2021 at 01:17.
Pushed by ngraham into branch 'Plasma/5.18'.

[lookandfeel] Fix wake existing screensaver mode with key presses

In commit 45e0a722fb85bb5d1ab8bef92080e934254b13aa we changed the focus
on the textfield with the intention of fixing the cusor blinking.

This had the unfortunate side effect of breaking waking out of the
screensaver mode with just the keyboard.

That screensaver mode was bound to:
```
property bool blockUI: mainBlock.mainPasswordBox.text.length > 0
```
for that to change, we need to have focus.

Instead this patches cursor blinking more explicity.

Doing it only in the lock screen (as opposed to the toolkit) makes sense
as this only happens due to somewhat unusual usage inside the
lockscreen.


(cherry picked from commit 2cbd7e4c70d0592d16cdaf58ed43effe4a716aa4)

M  +0    -3    lookandfeel/contents/lockscreen/LockScreenUi.qml
M  +6    -0    lookandfeel/contents/lockscreen/MainBlock.qml

https://invent.kde.org/plasma/plasma-workspace/commit/13057013d55ae19e76d29b9edc96510e52da2a7a
Comment 5 Nicolas Fella 2021-01-11 16:17:06 UTC
*** Bug 431427 has been marked as a duplicate of this bug. ***
Comment 6 Nicolas Fella 2021-01-23 21:12:16 UTC
*** Bug 431966 has been marked as a duplicate of this bug. ***
Comment 7 Nicolas Fella 2021-01-24 13:00:27 UTC
*** Bug 432028 has been marked as a duplicate of this bug. ***