Bug 428754 - KDEConnect shows notification on desktop if VLC is paused on desktop
Summary: KDEConnect shows notification on desktop if VLC is paused on desktop
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: android-application (show other bugs)
Version: 1.10
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Albert Vaca Cintora
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-06 11:56 UTC by postix
Modified: 2020-12-07 19:52 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot (63.41 KB, image/png)
2020-11-06 11:56 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2020-11-06 11:56:12 UTC
Created attachment 133079 [details]
Screenshot

SUMMARY

Since I updated to Plasma 5.20.2 and KDEConnect 1.15.1 on Android, KDEConnect shows a notification on the desktop
whenever I pause the playback in the VLC on the desktop. This is of course redundant. 

It would only make sense to show this notification if the playback was paused via the phone, which is already happening.



SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.20.2
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.1
KDEConnect Android: 1.15.1 (F-Droid)
Comment 1 postix 2020-11-06 17:04:39 UTC
Same happens eg for YouTube videos in the Firefox 82 Browser + Plasma Addon.
Comment 2 Daniel 2020-11-11 11:26:09 UTC
Can confirm. As far as I can tell it happens with every media player which supports MPRIS, and for that KDEConnect sends a media control notification to Android, from there a new notification is sent to the PC/other devices.
Comment 3 Filip 2020-11-11 12:28:04 UTC
(In reply to Daniel from comment #2)
> Can confirm. As far as I can tell it happens with every media player which
> supports MPRIS, and for that KDEConnect sends a media control notification
> to Android, from there a new notification is sent to the PC/other devices.
+1

Disabling media control notification plugin on Android works around the issue btw.
Comment 4 Nicolas Fella 2020-12-07 19:52:05 UTC
Git commit f6ca187fb214989b3cdcf092c3f2a7aede28d653 by Nicolas Fella.
Committed on 07/12/2020 at 19:51.
Pushed by nicolasfella into branch 'master'.

Fix not sending our own notification

This got broken during some MMS work.
Related: bug 428715

M  +2    -8    src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java

https://invent.kde.org/network/kdeconnect-android/commit/f6ca187fb214989b3cdcf092c3f2a7aede28d653