Bug 428109 - Fitts' Law broken for non-taskmanager panel applets
Summary: Fitts' Law broken for non-taskmanager panel applets
Status: RESOLVED DUPLICATE of bug 423390
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: master
Platform: Other Linux
: HI normal
Target Milestone: 1.0
Assignee: veggero
URL:
Keywords: multiscreen, regression
: 431884 431992 432013 432281 432586 446880 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-10-22 17:00 UTC by Kai Uwe Broulik
Modified: 2022-07-03 15:34 UTC (History)
12 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21


Attachments
Screenshot of Panel before the update (22.11 KB, image/png)
2021-01-25 19:41 UTC, magiblot
Details
Screenshot of Panel after update (20.74 KB, image/png)
2021-01-25 19:43 UTC, magiblot
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2020-10-22 17:00:29 UTC
With recent panel margin/padding changes, there's now padding on left and right side of the panel which means the applets there don't touch the screen border anymore.


STEPS TO REPRODUCE
1. Have a maximized horizontal panel with e.g. Kickoff in it as its leftmost applet
2. Move mouse all the way to the left and try clicking Kickoff

OBSERVED RESULT
Doesn't open, I click the panel

EXPECTED RESULT
Opens Kickoff like before

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: plasma-desktop git msater from 2020-10-21

ADDITIONAL INFORMATION
The margins are applied in plasma-desktop/containments/panel/contents/ui/main.qml

    anchors {
        leftMargin: currentLayout.isLayoutHorizontal ? panelSvg.fixedMargins.left : 0
        rightMargin: currentLayout.isLayoutHorizontal ? panelSvg.fixedMargins.right : 0
        topMargin: currentLayout.isLayoutHorizontal ? 0 : panelSvg.fixedMargins.top
        bottomMargin: currentLayout.isLayoutHorizontal ? 0 : panelSvg.fixedMargins.bottom
    }

I think using fixedMargins is incorrect here as the panel is not supposed to have margins when touching a screen edge.
Comment 1 Nate Graham 2020-10-26 17:12:29 UTC
Cannot reproduce. I have a full side margin and am able to click on Kickoff's panel icon using the left-most pixel.

Niccolò, can you reproduce and/or investigate?
Comment 2 veggero 2020-10-26 17:18:33 UTC
Kai: I assume that clicking on the rightmost pixel of the panel does not trigger show desktop either?
Comment 3 Kai Uwe Broulik 2020-10-28 15:39:24 UTC
It does not, correct.
Comment 4 Nate Graham 2020-12-17 19:39:10 UTC
Are you still seeing this with git master? It works fine for me with panels on any edge using a 200% scale factor, either with or without Qt scaling turned on.
Comment 5 Bug Janitor Service 2021-01-01 04:39:13 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Bug Janitor Service 2021-01-16 04:37:57 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!
Comment 7 Nate Graham 2021-01-22 17:47:31 UTC
*** Bug 431884 has been marked as a duplicate of this bug. ***
Comment 8 Nate Graham 2021-01-22 17:48:00 UTC
Got another report of this in the beta; re-opening.
Comment 9 Nate Graham 2021-01-22 17:48:25 UTC
Kai, can you still reproduce this? I still cannot.
Comment 10 Nicolas Fella 2021-01-24 21:42:20 UTC
*** Bug 432013 has been marked as a duplicate of this bug. ***
Comment 11 Nicolas Fella 2021-01-24 21:44:59 UTC
I can reproduce this for the bottom edge of the panel.

This includes the start menu, pager, system tray and clock, i.e. anything but the task manager
Comment 12 Nate Graham 2021-01-25 17:47:07 UTC
Bug 432013 seems different, unless you think the root cause is the same.

Regardless, I can reproduce the issue described in Bug 432013 with a horizontal panel, and after the recent fix for vertical panels, it's now affecting my vertical panel as well.

A workaround is to remove the Margins Separator applet from the panel.

Niccolò, please prioritize fixing this before the Plasma 5.21 final release.
Comment 13 veggero 2021-01-25 17:49:34 UTC
Managed to reproduce today, working on a fix :)
Comment 14 Nate Graham 2021-01-25 18:12:18 UTC
Thanks!
Comment 15 magiblot 2021-01-25 19:41:16 UTC
Created attachment 135177 [details]
Screenshot of Panel before the update
Comment 16 magiblot 2021-01-25 19:43:02 UTC
Created attachment 135178 [details]
Screenshot of Panel after update

Here are two screenshots comparing the Panel before and after the update. It can be seen that margins have grown, and that widgets like the pager and the clock now look smaller (and uglier).
Comment 17 veggero 2021-01-25 19:46:44 UTC
The change in margins is intended.
Comment 18 Nate Graham 2021-01-26 03:30:27 UTC
*** Bug 431992 has been marked as a duplicate of this bug. ***
Comment 19 Bug Janitor Service 2021-01-27 17:27:00 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/328
Comment 20 veggero 2021-01-27 17:27:36 UTC
The MR fixes it for me; can you confirm that?
Comment 21 Matej Mrenica 2021-01-27 17:49:23 UTC
It does for me too.
Comment 22 Nate Graham 2021-01-29 19:05:53 UTC
*** Bug 432281 has been marked as a duplicate of this bug. ***
Comment 23 Nate Graham 2021-02-06 17:18:30 UTC
Fixed by Niccolò Venerandi with https://invent.kde.org/plasma/plasma-desktop/-/commit/c540181a80a8a23659fdb43ed75f8d391cda47d3 in Plasma 5.21!
Comment 24 Nate Graham 2021-02-06 23:06:59 UTC
*** Bug 432586 has been marked as a duplicate of this bug. ***
Comment 25 Tomas 2021-06-10 01:57:41 UTC
Same problem in kubuntu 21.04 plasma 5.21.4. Margins in 5.21 are really messed up. Also icons in panel are very small because of margins
Comment 26 Nate Graham 2021-06-10 02:51:21 UTC
The issue you're having seems like a different one from this. Can yo please open a new bug report for it?
Comment 27 Nate Graham 2021-12-15 20:10:45 UTC
*** Bug 446880 has been marked as a duplicate of this bug. ***
Comment 28 Nate Graham 2021-12-15 20:11:14 UTC
Got a duplicate report from someone using Plasma 5.23.4; re-opening.
Comment 29 Paul McAuley 2021-12-28 17:31:35 UTC
I am now just experiencing this on 5.23.4 with a bottom panel and an application launcher at the extreme bottom-left. The extreme bottom-left corner does not trigger the application launcher, and the extreme bottom-right corner does not trigger show desktop.  It has only appeared for me as a problem on recent builds. 

It does not occur if I use a panel at the left with the application launcher at the top-left corner.
Comment 30 Paul McAuley 2021-12-28 17:34:41 UTC
(In reply to Paul McAuley from comment #29)
> I am now just experiencing this on 5.23.4 with a bottom panel and an
> application launcher at the extreme bottom-left. The extreme bottom-left
> corner does not trigger the application launcher, and the extreme
> bottom-right corner does not trigger show desktop.  It has only appeared for
> me as a problem on recent builds. 
> 
> It does not occur if I use a panel at the left with the application launcher
> at the top-left corner.

Some more info: I am using 250% scaling, on X11, have PLASMA_USE_QT_SCALING on and have a panel height of 40, no margin separators.
Comment 31 Derek Christ 2021-12-29 19:23:12 UTC
I'll add my infos from Bug 446880 too:
Can reproduce the bug with scaling set to 2x (4k resolution) on X11. The bug does not occur with 1x scaling. Also, the Wayland session is not affected by this bug.
Comment 32 Nate Graham 2022-01-29 03:10:32 UTC
For anyone who can reproduce this, can you answer the following questions:
1. What side of the screen is your panel located on?
2. On which screen edge is Fitts' Law broken for?
2. What is your screen resolution?
3. What is your scaling factor?
4. Are you running Plasma on X11 with PLASMA_USE_QT_SCALING=1?
4a. If so, does the problem go away if you unset that and restart plasmashell?
5. Does it reproduce on Wayland too, or just X11?

Thanks in advance. :)
Comment 33 Derek Christ 2022-02-03 20:05:06 UTC
(In reply to Nate Graham from comment #32)
> For anyone who can reproduce this, can you answer the following questions:
> 1. What side of the screen is your panel located on?
> 2. On which screen edge is Fitts' Law broken for?
> 2. What is your screen resolution?
> 3. What is your scaling factor?
> 4. Are you running Plasma on X11 with PLASMA_USE_QT_SCALING=1?
> 4a. If so, does the problem go away if you unset that and restart
> plasmashell?
> 5. Does it reproduce on Wayland too, or just X11?
> 
> Thanks in advance. :)

1. Bottom
2. Bottom is broken, the left side works
2. 3840x2160
3. 2x
4. Yes
4a. At first yes, but the panel is smaller when the variable is not set. After resizing to the previous visual size the problem persists but this time also for the left screen edge.
5. In Wayland everything works fine.
Comment 34 Nate Graham 2022-02-03 20:08:41 UTC
I suspected that this was a PLASMA_USE_QT_SCALING=1 thing. After much investigation (see Bug 356446), we have unfortunately found that it's not feasible to turn this on by default for X11, which means that using it manually is unsupported.

Unfortunately I think we have to close this. Folks who want a decent hidpi experience will have to use Wayland and look forward to upcoming changes to improve the experience for XWayland apps in particular.

Sorry everyone. :(
Comment 35 Fushan Wen 2022-07-03 15:31:35 UTC

*** This bug has been marked as a duplicate of bug 423390 ***