SUMMARY ...because it's impossible to "safely remove" non-removable devices. STEPS TO REPRODUCE 1. open Disks & Devices systray applet 2. open "Show" combobox and choose "All devices" or "Non-removable devices" 3. hover over a partition of an internal device OBSERVED RESULT we see a button labeled "Safely remove" EXPECTED RESULT the button should be labeled "Unmount" SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.19.90 KDE Frameworks Version: 5.74.0 Qt Version: 5.15.1
Same bug as Bug 427175, ultimately. This button shouldn't be appearing at all in this case. *** This bug has been marked as a duplicate of bug 427175 ***
This issue persists. Operating System: Arch Linux KDE Plasma Version: 5.20.0 KDE Frameworks Version: 5.75.0 Qt Version: 5.15.1
...But how? Can you share a screenshot? It's working for me.
Created attachment 132321 [details] screenshot Here is a screenshot.
Oh! I think I misunderstood the issue. I can see what you mean now. Not a regression, but something that's now more obvious now that we make it easy to see non-removable devices in the applet.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/354
Git commit 677d5dd872efae7c08015ea88454fdb991dc2fdf by Nate Graham. Committed on 16/10/2020 at 20:55. Pushed by ngraham into branch 'master'. [applets/devicenotifier] Don't offer to unmount non-removable devices The previous check for whether a device was non-removable in the delegate was faulty and was doing too much work, which caused it to miss non-root internal disks. In fact, we can already get this data straight from the data engine. This fixes the bug and removes code in net. FIXED-IN: 5.20.1 M +3 -7 applets/devicenotifier/package/contents/ui/DeviceItem.qml https://invent.kde.org/plasma/plasma-workspace/commit/677d5dd872efae7c08015ea88454fdb991dc2fdf
Git commit 59ce9a3e9f162992e5158c3a5eaebf2ef3352eae by Nate Graham. Committed on 16/10/2020 at 20:56. Pushed by ngraham into branch 'Plasma/5.20'. [applets/devicenotifier] Don't offer to unmount non-removable devices The previous check for whether a device was non-removable in the delegate was faulty and was doing too much work, which caused it to miss non-root internal disks. In fact, we can already get this data straight from the data engine. This fixes the bug and removes code in net. FIXED-IN: 5.20.1 (cherry picked from commit 677d5dd872efae7c08015ea88454fdb991dc2fdf) M +3 -7 applets/devicenotifier/package/contents/ui/DeviceItem.qml https://invent.kde.org/plasma/plasma-workspace/commit/59ce9a3e9f162992e5158c3a5eaebf2ef3352eae