Bug 427175 - "Remove all" button does nothing when Disks & Devices applet is showing non-removable devices
Summary: "Remove all" button does nothing when Disks & Devices applet is showing non-r...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Disks & Devices (show other bugs)
Version: 5.19.90
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-30 19:31 UTC by Patrick Silva
Modified: 2020-10-05 21:36 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/commit/410362c1bf963a83c75ee48c105abf780e485b0f
Version Fixed In: 5.20
Sentry Crash Report:

Attachments
screenshot (50.90 KB, image/png)
2020-10-05 21:16 UTC, Patrick Silva 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-09-30 19:31:34 UTC 
STEPS TO REPRODUCE
1. have two or more partitions of internal devices on your system
2. open Disks & Devices systray applet
3. open "Show" combobox on top and choose "Non-removable devices" ("Remove all" button is available despite all listed devices are non-removable)
4. click on "Remove all" button

OBSERVED RESULT
nothing happens

EXPECTED RESULT
I do not know the purpose of this "Remove all" button. Unmount all non-removable devices?
If so, it's not working and its label is inaccurate. If we do not want to unmount non-removable devices, then should not exist a "Remove all" button when Disks & Devices applet is only showing non-removable devices.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.19.90
KDE Frameworks Version: 5.74.0
Qt Version: 5.15.1

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2020-10-05 20:23:25 UTC 
The button is only supposed to appear when there are more than one removable devices attached. This is what I see; I don't see the button when the applet is displaying only non-removable devices. Is that what you see? Can I have a screenshot?
Comment 2 Nate Graham 2020-10-05 20:24:06 UTC 
*** Bug 427176 has been marked as a duplicate of this bug. ***
Comment 3 Patrick Silva 2020-10-05 21:16:18 UTC 
Created attachment 132137 [details]
screenshot
Comment 4 Nate Graham 2020-10-05 21:29:04 UTC 
Thanks. Found the bug. Dunno if this is a regression from the previous one or nor, but either way, I'll fix it.
Comment 5 Nate Graham 2020-10-05 21:36:31 UTC 
Git commit a9cef6070fdba0c0cab51f9f364cd31e1886e2c7 by Nate Graham.
Committed on 05/10/2020 at 21:34.
Pushed by ngraham into branch 'master'.

[applets/devicenotifier] Be more selective about showing "Remove all" button

This button only makes sense to show when using the "Removable devices"
setting in the combobox.
FIXED-IN: 5.20

M  +4    -1    applets/devicenotifier/package/contents/ui/FullRepresentation.qml

https://invent.kde.org/plasma/plasma-workspace/commit/a9cef6070fdba0c0cab51f9f364cd31e1886e2c7
Comment 6 Nate Graham 2020-10-05 21:36:59 UTC 
Git commit 410362c1bf963a83c75ee48c105abf780e485b0f by Nate Graham.
Committed on 05/10/2020 at 21:36.
Pushed by ngraham into branch 'Plasma/5.20'.

[applets/devicenotifier] Be more selective about showing "Remove all" button

This button only makes sense to show when using the "Removable devices"
setting in the combobox.
FIXED-IN: 5.20
(cherry picked from commit a9cef6070fdba0c0cab51f9f364cd31e1886e2c7)

M  +4    -1    applets/devicenotifier/package/contents/ui/FullRepresentation.qml

https://invent.kde.org/plasma/plasma-workspace/commit/410362c1bf963a83c75ee48c105abf780e485b0f