Bug 424919 - update of addons from KDE Store fails silently
Summary: update of addons from KDE Store fails silently
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: KNewStuff Backend (show other bugs)
Version: 5.19.90
Platform: Arch Linux Linux
: VHI normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
: 428709 428730 428812 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-08-02 12:53 UTC by Patrick Silva
Modified: 2020-11-09 17:37 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.76


Attachments
screenshot (100.63 KB, image/png)
2020-09-28 11:04 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-08-02 12:53:10 UTC
SUMMARY
I'm trying to update icon themes installed from KDE Store.
Apparently the updates are successfully installed because Discover shows no error message and the updates disappear from the "Update" page, but they reappears when Discover is restarted.

Konsole shows these errors:

kf.newstuff.core: "Connection closed"
KNS error in "Icons" : KNSCore::InstallationError "Download of \"Tela circle icon theme\" failed, error: Connection closed" QVariant(Invalid)
kns error "/usr/share/knsrcfiles/icons.knsrc" "Download of \"Tela circle icon theme\" failed, error: Connection closed"
qml: message: icons.knsrc: Download of "Tela circle icon theme" failed, error: Connection closed
kf.newstuff.core: "Connection closed"
KNS error in "Icons" : KNSCore::InstallationError "Download of \"Papirus\" failed, error: Connection closed" QVariant(Invalid)
kns error "/usr/share/knsrcfiles/icons.knsrc" "Download of \"Papirus\" failed, error: Connection closed"
qml: message: icons.knsrc: Download of "Papirus" failed, error: Connection closed

STEPS TO REPRODUCE
1. try to update addons from KDE Store with Discover
2. 
3. 

OBSERVED RESULT
update process fails without any error message

EXPECTED RESULT
successful update

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.73.0
Qt Version: 5.14.2

ADDITIONAL INFORMATION
Discover says "Can't pull from untrusted non-gpg verified remote" on opening.
I'm not sure if it has something to do with this bug.
Comment 1 Nate Graham 2020-08-04 13:24:33 UTC
Fixed in 5.20.
Comment 2 Patrick Silva 2020-08-16 13:29:05 UTC
This issue persists on neon unstable based on ubuntu 20.04.
I'm trying update Oreo Cursors cursor theme but it always reappears in "Update" page after Discover to be restarted. Even update via GHNS window of Cursors kcm is failing silencently.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2
Comment 3 Alexander Lohnau 2020-09-19 15:40:24 UTC
>I'm trying update Oreo Cursors cursor theme but it always reappears in "Update" page after Discover to be restarted. Even update via GHNS window of Cursors kcm is failing silencently.

Sounds like the exact same issue that got fixed in https://invent.kde.org/frameworks/knewstuff/-/merge_requests/54, can you confirm this?
Comment 4 Patrick Silva 2020-09-19 16:07:25 UTC
(In reply to Alexander Lohnau from comment #3)
> >I'm trying update Oreo Cursors cursor theme but it always reappears in "Update" page after Discover to be restarted. Even update via GHNS window of Cursors kcm is failing silencently.
> 
> Sounds like the exact same issue that got fixed in
> https://invent.kde.org/frameworks/knewstuff/-/merge_requests/54, can you
> confirm this?

I have just uninstalled all my widgets and reinstall them.
I will test when updates are available.
Comment 5 Patrick Silva 2020-09-28 11:04:15 UTC
Created attachment 131981 [details]
screenshot

I have just tried to update Newaita icon theme, GHNS failed silently but Discover shown error messages. See the attached screenshot please.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.75.0
Qt Version: 5.15.0
Comment 6 Patrick Silva 2020-09-28 11:28:16 UTC
(In reply to Patrick Silva from comment #5)
> I have just tried to update Newaita icon theme, GHNS failed silently...

I meant GHNS window failed silently.
Comment 7 Justin Zobel 2020-11-04 05:25:56 UTC
I have this issue as well, the Paprius item appears under Addons updates every time.

It is 7 bytes and is the update from 20201001 > 20201031.
Comment 8 Nate Graham 2020-11-04 06:08:50 UTC
I still have it too. :(
Comment 9 lucasrizzini 2020-11-05 09:02:55 UTC
Same here. Still happening on 5.20.
Comment 10 lucasrizzini 2020-11-05 09:04:37 UTC
(In reply to lucasrizzini from comment #9)
> Same here. Still happening on 5.20.

My reddit post about it: https://www.reddit.com/r/kde/comments/jiz5cs/has_anyone_managed_to_update_kde_extensions_using/
Comment 11 Nate Graham 2020-11-05 14:57:24 UTC
*** Bug 428709 has been marked as a duplicate of this bug. ***
Comment 12 Patrick Silva 2020-11-05 21:38:33 UTC
*** Bug 428730 has been marked as a duplicate of this bug. ***
Comment 13 Alexander Lohnau 2020-11-07 10:24:17 UTC
>I have this issue as well, the Paprius item appears under Addons updates every time.

Do you mean https://store.kde.org/p/1012267?

This project hasn't been updated in the last few years, I wonder why that should show up as updatable.

Also it appears that it is has an issue with persisting the state: When yo download it it gets marked as installed, when you reopen the KCM it gets removed from the list of installed entries. This seems related to the download being from an external link. There has been a discussion about disabling this because of security concerns. And if one points the link to the zip which gets dynamically updated KNS has no chance of knowing if the file was updated without downloading it.
Comment 14 Alexander Lohnau 2020-11-07 10:39:14 UTC
(In reply to Patrick Silva from comment #5)
> Created attachment 131981 [details]
> screenshot
> 
> I have just tried to update Newaita icon theme, GHNS failed silently but
> Discover shown error messages. See the attached screenshot please.

https://store.kde.org/p/1243493/ has the hint:
> Latest version	GITHUB (do not use libzip)

So it seems that this is again related to the download of external files.

@Patrick Does the same thing happen in case of the other non-external files?
Comment 15 Patrick Silva 2020-11-08 10:54:54 UTC
I have just tried to update 4 addons on neon unstable:
bibata cursor theme
newaita icon theme
papirus icon theme
event calendar plasma widget

Results:
bibata was successfully updated;
newaita causes the same error messages shown in my screenshot;
papitus and event calendar are apparently updated (no error message), but they reappear in the updates list after I restart Discover.
Comment 16 Alexander Lohnau 2020-11-08 11:48:20 UTC
@Patrick I have played a bit around and found that sometimes when installing new icon themes they appear as installed after installing them, but are uninstalled after restarting the KCM. Can you confirm this? I had it quite often, but now always.

It might be related, because my suspicion is that the entries do not get properly persisted to the XML file.
Comment 17 Patrick Silva 2020-11-08 13:38:01 UTC
(In reply to Alexander Lohnau from comment #16)
> @Patrick I have played a bit around and found that sometimes when installing
> new icon themes they appear as installed after installing them, but are
> uninstalled after restarting the KCM. Can you confirm this?

Yes, I can. Installed icon themes are no longer marked as installed in GHNS window after I reopen it. But the installed icon themes are still available for selection in Icons KCM.
Comment 18 Nate Graham 2020-11-08 17:58:49 UTC
I can reproduce this with https://store.kde.org/p/1316544.
Comment 20 Alexander Lohnau 2020-11-09 10:19:33 UTC
Git commit c15fbc05dbc275ef1bd85f1578c078f6a873909c by Alexander Lohnau.
Committed on 09/11/2020 at 10:16.
Pushed by alex into branch 'master'.

Remove entry from cache before inserting new entry

"If value already exists in the set, the set is left unchanged"
https://doc.qt.io/qt-5/qset.html#insert

M  +1    -0    src/core/cache.cpp

https://invent.kde.org/frameworks/knewstuff/commit/c15fbc05dbc275ef1bd85f1578c078f6a873909c
Comment 21 Nate Graham 2020-11-09 17:37:52 UTC
*** Bug 428812 has been marked as a duplicate of this bug. ***